Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Support returning data out of with_children #4708

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - Support returning data out of with_children #4708

wants to merge 9 commits into from

Commits on May 9, 2022

  1. Support returning data out of with_children 

    Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
    @SUPERCILEX
    SUPERCILEX committed May 9, 2022
    Configuration menu
    Copy the full SHA
    3697221 View commit details
    Browse the repository at this point in the history

  2. Make clippy happy 

    Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
    @SUPERCILEX
    SUPERCILEX committed May 9, 2022
    Configuration menu
    Copy the full SHA
    f8128e5 View commit details
    Browse the repository at this point in the history

  3. Dang it 

    Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
    @SUPERCILEX
    SUPERCILEX committed May 9, 2022
    Configuration menu
    Copy the full SHA
    c5c4d21 View commit details
    Browse the repository at this point in the history

  4. More lifetime pain and suffering 

    Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
    @SUPERCILEX
    SUPERCILEX committed May 9, 2022
    Configuration menu
    Copy the full SHA
    2101e88 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2022

  1. Switch to add_children method 

    Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
    @SUPERCILEX
    SUPERCILEX committed May 16, 2022
    Configuration menu
    Copy the full SHA
    6a224ff View commit details
    Browse the repository at this point in the history

Commits on May 17, 2022

  1. Add docs example 

    Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
    @SUPERCILEX
    SUPERCILEX committed May 17, 2022
    Configuration menu
    Copy the full SHA
    cc4a311 View commit details
    Browse the repository at this point in the history

  2. Update crates/bevy_hierarchy/src/child_builder.rs 

    Co-authored-by: Daniel McNab <36049421+DJMcNab@users.noreply.github.com>
    @SUPERCILEX @DJMcNab
    SUPERCILEX and DJMcNab authored May 17, 2022
    Configuration menu
    Copy the full SHA
    8cbeeca View commit details
    Browse the repository at this point in the history

  3. Address review feedback 

    Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
    @SUPERCILEX
    SUPERCILEX committed May 17, 2022
    Configuration menu
    Copy the full SHA
    2b48828 View commit details
    Browse the repository at this point in the history

  4. Add doc line 

    Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
    @SUPERCILEX
    SUPERCILEX committed May 17, 2022
    Configuration menu
    Copy the full SHA
    c1eb1ea View commit details
    Browse the repository at this point in the history