Remove FetchState #4802
Closed
Remove FetchState #4802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
added
A-ECS
|
This is basically ready, but #4807 should probably be merged first. |
|
#4807 has been checked in. Taking this out of draft. |
BoxyUwU
suggested changes
May 31, 2022
BoxyUwU
approved these changes
Jun 1, 2022
|
This has been superseded by #5205, which does this and further collapses the WorldQuery trait hierarchy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
FetchStateadds a bit of additional type/trait impl bloat. Slim down ECS's compilation by moving the implementation toFetchinstead.Solution
Move the implementations onto their associated
Fetchinstead, remove the old implementations.I tried putting this on
WorldQueryinstead, but it snagged on some of theFetchimpls for some of the filters.Changelog
TODO
Migration Guide
TODO