[Merged by Bors] - Derive thiserror::Error for HexColorError (again) #4847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Code-Quality
|
@cart am I right that you removed the derive by accident? |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 30, 2022
This was first done in 7b4e3a5, but was then reverted when the new renderer for 0.6 was merged (ffecb05). I'm assuming it was simply a mistake when merging. # Objective - Same as #2740, I think it was reverted by mistake when merging. > # Objective > > - Make it easy to use HexColorError with `thiserror`, i.e. converting it into other error types. > > Makes this possible: > > ```rust > #[derive(Debug, thiserror::Error)] > pub enum LdtkError { > #[error("An error occured while deserializing")] > Json(#[from] serde_json::Error), > #[error("An error occured while parsing a color")] > HexColor(#[from] bevy::render::color::HexColorError), > } > ``` > > ## Solution > > - Derive thiserror::Error the same way we do elsewhere (see query.rs for instance)
bors
bot
changed the title
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Jun 7, 2022
This was first done in 7b4e3a5, but was then reverted when the new renderer for 0.6 was merged (ffecb05). I'm assuming it was simply a mistake when merging. # Objective - Same as bevyengine#2740, I think it was reverted by mistake when merging. > # Objective > > - Make it easy to use HexColorError with `thiserror`, i.e. converting it into other error types. > > Makes this possible: > > ```rust > #[derive(Debug, thiserror::Error)] > pub enum LdtkError { > #[error("An error occured while deserializing")] > Json(#[from] serde_json::Error), > #[error("An error occured while parsing a color")] > HexColor(#[from] bevy::render::color::HexColorError), > } > ``` > > ## Solution > > - Derive thiserror::Error the same way we do elsewhere (see query.rs for instance)
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
This was first done in 7b4e3a5, but was then reverted when the new renderer for 0.6 was merged (ffecb05). I'm assuming it was simply a mistake when merging. # Objective - Same as bevyengine#2740, I think it was reverted by mistake when merging. > # Objective > > - Make it easy to use HexColorError with `thiserror`, i.e. converting it into other error types. > > Makes this possible: > > ```rust > #[derive(Debug, thiserror::Error)] > pub enum LdtkError { > #[error("An error occured while deserializing")] > Json(#[from] serde_json::Error), > #[error("An error occured while parsing a color")] > HexColor(#[from] bevy::render::color::HexColorError), > } > ``` > > ## Solution > > - Derive thiserror::Error the same way we do elsewhere (see query.rs for instance)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was first done in 7b4e3a5, but was then reverted when the new
renderer for 0.6 was merged (ffecb05).
I'm assuming it was simply a mistake when merging.
Objective