-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Update gilrs to v0.9 #4848
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
two duplicate dependencies:
|
james7132
added
C-Bug
An unexpected or incorrect behavior
A-Input
Player input via keyboard, mouse, gamepad, and more
C-Dependencies
A change to the crates that Bevy depends on
O-Web
Specific to web (WASM) builds
labels
May 26, 2022
mockersf
reviewed
May 26, 2022
Co-authored-by: François <mockersf@gmail.com>
mockersf
approved these changes
May 26, 2022
bors r+ |
alice-i-cecile
added
the
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
label
May 30, 2022
alice-i-cecile
approved these changes
May 30, 2022
bors bot
pushed a commit
that referenced
this pull request
May 30, 2022
# Objective Fixes #4353. Fixes #4431. Picks up fixes for a panic for `gilrs` when `getGamepads()` is not available. ## Solution Update the `gilrs` to `v0.9.0`. Changelog can be seen here: https://gitlab.com/gilrs-project/gilrs/-/commit/dba36f91869c823fb66f8633d2b650b430682f80 EDIT: Updated `uuid` to 1.1 to avoid duplicate dependencies. Added `nix`'s two dependencies as exceptions until `rodio` updates their deps.
bors
bot
changed the title
Update gilrs to v0.9
[Merged by Bors] - Update gilrs to v0.9
May 30, 2022
james7132
added a commit
to james7132/bevy
that referenced
this pull request
Jun 7, 2022
# Objective Fixes bevyengine#4353. Fixes bevyengine#4431. Picks up fixes for a panic for `gilrs` when `getGamepads()` is not available. ## Solution Update the `gilrs` to `v0.9.0`. Changelog can be seen here: https://gitlab.com/gilrs-project/gilrs/-/commit/dba36f91869c823fb66f8633d2b650b430682f80 EDIT: Updated `uuid` to 1.1 to avoid duplicate dependencies. Added `nix`'s two dependencies as exceptions until `rodio` updates their deps.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Fixes bevyengine#4353. Fixes bevyengine#4431. Picks up fixes for a panic for `gilrs` when `getGamepads()` is not available. ## Solution Update the `gilrs` to `v0.9.0`. Changelog can be seen here: https://gitlab.com/gilrs-project/gilrs/-/commit/dba36f91869c823fb66f8633d2b650b430682f80 EDIT: Updated `uuid` to 1.1 to avoid duplicate dependencies. Added `nix`'s two dependencies as exceptions until `rodio` updates their deps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Input
Player input via keyboard, mouse, gamepad, and more
C-Bug
An unexpected or incorrect behavior
C-Dependencies
A change to the crates that Bevy depends on
O-Web
Specific to web (WASM) builds
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #4353. Fixes #4431. Picks up fixes for a panic for
gilrs
whengetGamepads()
is not available.Solution
Update the
gilrs
tov0.9.0
. Changelog can be seen here: https://gitlab.com/gilrs-project/gilrs/-/commit/dba36f91869c823fb66f8633d2b650b430682f80EDIT: Updated
uuid
to 1.1 to avoid duplicate dependencies. Addednix
's two dependencies as exceptions untilrodio
updates their deps.