Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Remove dead SystemLabelMarker struct #5190

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Remove dead SystemLabelMarker struct #5190

wants to merge 1 commit into from

Conversation

alice-i-cecile
Copy link
Member

This struct had no internal use, docs, or intuitable external use.

It has been removed.

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Jul 4, 2022
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jul 4, 2022
@alice-i-cecile
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Jul 4, 2022
@alice-i-cecile
Remove dead SystemLabelMarker struct (#5190)
2c9bc0b 
This struct had no internal use, docs, or intuitable external use.

It has been removed.
@bors
Copy link
Contributor

bors bot commented Jul 4, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Remove dead SystemLabelMarker struct [Merged by Bors] - Remove dead SystemLabelMarker struct Jul 4, 2022
@bors bors bot closed this Jul 4, 2022
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
@alice-i-cecile @inodentry
Remove dead SystemLabelMarker struct (bevyengine#5190)
d8c2dad 
This struct had no internal use, docs, or intuitable external use.

It has been removed.
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@alice-i-cecile @james7132
Remove dead SystemLabelMarker struct (bevyengine#5190)
d465425 
This struct had no internal use, docs, or intuitable external use.

It has been removed.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@alice-i-cecile @ItsDoot
Remove dead SystemLabelMarker struct (bevyengine#5190)
b0aff12 
This struct had no internal use, docs, or intuitable external use.

It has been removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nilirad Nilirad Nilirad approved these changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alice-i-cecile @mockersf @tim-blackbird @Nilirad