Use exact version of async-executor in bevy_tasks #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 1.3.1 of async-executor requires a lifetime on Executor. Due to the way that cargo fetches dependencies, without the '=' or Cargo.lock file, cargo can compile with a later version leading to compilation errors.
|
Note, if others are currently getting this issue when compiling bevy for the first time in their projects, you can add to your Cargo.toml dependencies. |
|
Note sure how about building the CI to check for these sort of external dependency issues. Maybe checkin Cargo.lock files? |
mcpar-land
added a commit
to mcpar-land/bevy_fly_camera
that referenced
this pull request
Sep 20, 2020
- fixed bug related to PR bevyengine/bevy#532 - added enabled boolean - fixed errors in example - added enabled boolean toggle to example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 1.3.1 of async-executor requires a lifetime on Executor. Due
to the way that cargo fetches dependencies, without the '=' or
Cargo.lock file, cargo can compile with a later version leading to
compilation errors.