Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Derive AsBindGroup Improvements: Better errors, more options, update examples #5364

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - Derive AsBindGroup Improvements: Better errors, more options, update examples #5364

wants to merge 9 commits into from

Commits on Jul 18, 2022

  1. better errors, support more options via name-value pairs in texture a… 

    …nd sampler attributes.
    @wrapperup
    wrapperup committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    e9a961d View commit details
    Browse the repository at this point in the history

  2. update array_texture example to use AsBindGroup derive macro

    @wrapperup
    wrapperup committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    38fdaf9 View commit details
    Browse the repository at this point in the history

  3. run cargo fmt

    @wrapperup
    wrapperup committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    5ef96c5 View commit details
    Browse the repository at this point in the history

  4. remove unused binding constant and imports

    @wrapperup
    wrapperup committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    57c0e6a View commit details
    Browse the repository at this point in the history

  5. organize code, split out parsing, use Parse trait

    @wrapperup
    wrapperup committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    72d6cb4 View commit details
    Browse the repository at this point in the history

  6. support visibility, use ToTokens for attr args instead of quoting in … 

    …the main derive
    @wrapperup
    wrapperup committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    8501230 View commit details
    Browse the repository at this point in the history

  7. fix wrong symbol name for visibility

    @wrapperup
    wrapperup committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    042077b View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. proper hygiene for visibility flag, lowercased flags

    @wrapperup
    wrapperup committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    f65f88d View commit details
    Browse the repository at this point in the history

  2. don't error on non-ident attribute paths

    @wrapperup
    wrapperup committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    2fadaaf View commit details
    Browse the repository at this point in the history