Sprite Sheet Example: Skip "idle" frame.

[jmrepetti]

Objective

• Make running animation fluid skipping 'idle' frame.

Solution

• Replace TextureAtlas::from_grid() with TextureAtlas::from_grid_with_padding() and provide an offset of 1 tile.

The example is correct, is just the feeling that the animation loop is not seamless.

[mopsalarm]

Afaik with padding also skips the padding space between tiles. Did you intend to do that?
I needed to something similar in the past and just applied the offset to all the rects in the result of "from_grid".

[mockersf]

I don't think not loading the first frame is the correct fix for that. instead, in the animate_sprite system, index 0 should be skipped

[jmrepetti]

Thanks for the comments.

@mockersf At some point I think you'll have different animations and trigger them somehow. That's why I thought on loading the running animation from the beginning instead of skipping indexes.

@mopsalarm I understood that padding will be used if tiles have some paddings, but in this case they don't, so I set it to Vec2.Zero.

But as I said, the example is correct and is about sprite sheet, not animations per se. I'm new to Bevy and was trying out the examples. Need to learn more. feel free to reject this PR if makes no sense :)

[mockersf]

@mockersf At some point I think you'll have different animations and trigger them somehow. That's why I thought on loading the running animation from the beginning instead of skipping indexes.

In case of different animations, I think you should load only one texture atlas, not skipping any, and then say idle animation is frame 0 to 0 (in this case), running is frame 1 to 7, jumping 8 to 12, ...
You end up with ranges of index on which you'll iterate depending on the animation you play, not changing the texture atlas itself.

But as I said, the example is correct and is about sprite sheet, not animations per se. I'm new to Bevy and was trying out the examples. Need to learn more. feel free to reject this PR if makes no sense :)

It definitely looks better skipping the idle frame. It's funny how I never noticed it but now that you made the change it jumps to my eye 😄

[rparrett]

With #6861 merged, it looks like this can be closed.