WIP: Implemented #[bundle(ignore)] and #[bundle(nest)]
#5578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maccesch
changed the title
#[bundle(ignore)] and #[bundle(nest)]#[bundle(ignore)] and #[bundle(nest)]
|
Seems like you hit a weird github bug from pushing a hard reset to main to your branch: https://discord.com/channels/691052431525675048/692572690833473578/1004950265767661699 You might need to re-open this PR. |
|
Thanks! Yeah I created a new one. Is that ok? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #5559
Solution
Because the generated method
from_components()creates an instance ofSelfmy implementation requires any field type that is marked to be ignored to implementDefault.Migration Guide
In
#[derive(Bundle)]structs:#[bundle]=>#[bundle(nest)]