[Merged by Bors] - Fix window centering when scale_factor is not 1.0 #5582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rparrett
added
the
A-Windowing
mockersf
approved these changes
Aug 5, 2022
|
Can confirm that this does solve the issue on MacOS M1 with Retina display. |
maccesch
approved these changes
Aug 13, 2022
Weibye
approved these changes
Aug 27, 2022
Weibye
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 30, 2022
# Objective Fixes #5581 ## Solution `Window::scale_factor` already has logic for selecting the overridden or actual scale factor, so use it. I tested this with the displays I have access to, but more testing would be nice. This seems like a pretty straightforward bug/fix though. ## Changelog ### Fixed Fixed window centering on high-dpi displays.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective Fixes bevyengine#5581 ## Solution `Window::scale_factor` already has logic for selecting the overridden or actual scale factor, so use it. I tested this with the displays I have access to, but more testing would be nice. This seems like a pretty straightforward bug/fix though. ## Changelog ### Fixed Fixed window centering on high-dpi displays.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Fixes bevyengine#5581 ## Solution `Window::scale_factor` already has logic for selecting the overridden or actual scale factor, so use it. I tested this with the displays I have access to, but more testing would be nice. This seems like a pretty straightforward bug/fix though. ## Changelog ### Fixed Fixed window centering on high-dpi displays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #5581
Solution
Window::scale_factoralready has logic for selecting the overridden or actual scale factor, so use it.I tested this with the displays I have access to, but more testing would be nice. This seems like a pretty straightforward bug/fix though.
Changelog
Fixed
Fixed window centering on high-dpi displays.