Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add window resizing example #5813

Closed
wants to merge 13 commits into from

Conversation

Weibye
Copy link
Contributor

@Weibye Weibye commented Aug 27, 2022

Objective

@Weibye Weibye added C-Examples An addition or correction to our examples A-UI Graphical user interfaces, styles, layouts, and widgets labels Aug 27, 2022
@Weibye Weibye added A-Windowing Platform-agnostic interface layer to run your app in and removed A-UI Graphical user interfaces, styles, layouts, and widgets labels Aug 27, 2022
Copy link
Contributor

@TimJentzsch TimJentzsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add a video/GIF/screenshot of the example to the PR description, but the code makes sense to me :)

@Weibye
Copy link
Contributor Author

Weibye commented Aug 27, 2022

Would be nice to add a video/GIF/screenshot of the example to the PR description, but the code makes sense to me :)

My screen-recorder really does not like recording a window that changes in size. This is likely best tested if you check out the code 🙃

@TimJentzsch
Copy link
Contributor

Would be nice to add a video/GIF/screenshot of the example to the PR description, but the code makes sense to me :)

My screen-recorder really does not like recording a window that changes in size. This is likely best tested if you check out the code 🙃

Hmm right, that would probably only work if you record the whole screen. But no worries, it's fine as long as it works locally :)

@cart
Copy link
Member

cart commented Aug 29, 2022

bors r+

bors bot pushed a commit that referenced this pull request Aug 29, 2022
# Objective

- Adopted from #3836
- Example showcases how to request a new resolution
- Example showcases how to react to resolution changes


Co-authored-by: Andreas Weibye <13300393+Weibye@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Aug 30, 2022

@bors bors bot changed the title Add window resizing example [Merged by Bors] - Add window resizing example Aug 30, 2022
@bors bors bot closed this Aug 30, 2022
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
# Objective

- Adopted from bevyengine#3836
- Example showcases how to request a new resolution
- Example showcases how to react to resolution changes


Co-authored-by: Andreas Weibye <13300393+Weibye@users.noreply.github.com>
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

- Adopted from bevyengine#3836
- Example showcases how to request a new resolution
- Example showcases how to react to resolution changes


Co-authored-by: Andreas Weibye <13300393+Weibye@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Examples An addition or correction to our examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants