Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - improve panic messages for add_system_to_stage and add_system_set_to_stage #5847

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - improve panic messages for add_system_to_stage and add_system_set_to_stage #5847

wants to merge 1 commit into from

Conversation

merelymyself
Copy link
Contributor

Objective

Solution

  • Edit the panic message.

@NathanSWard NathanSWard added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-App Bevy apps and plugins labels Sep 1, 2022
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Sep 1, 2022
alice-i-cecile
alice-i-cecile approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Sep 2, 2022
@merelymyself
improve panic messages for add_system_to_stage and add_system_set_to_…
6b87fb0 
…stage (#5847)

# Objective

- Make the panic messages more specific and understandable.
- Fixes #5811 
## Solution

- Edit the panic message.

---
@bors
Copy link
Contributor

bors bot commented Sep 2, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title improve panic messages for add_system_to_stage and add_system_set_to_stage [Merged by Bors] - improve panic messages for add_system_to_stage and add_system_set_to_stage Sep 2, 2022
@bors bors bot closed this Sep 2, 2022
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@merelymyself @james7132
improve panic messages for add_system_to_stage and add_system_set_to_…
d1f0a16 
…stage (bevyengine#5847)

# Objective

- Make the panic messages more specific and understandable.
- Fixes bevyengine#5811 
## Solution

- Edit the panic message.

---
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@merelymyself @ItsDoot
improve panic messages for add_system_to_stage and add_system_set_to_…
8e1bc5f 
…stage (bevyengine#5847)

# Objective

- Make the panic messages more specific and understandable.
- Fixes bevyengine#5811 
## Solution

- Edit the panic message.

---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@djeedai djeedai djeedai approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-App Bevy apps and plugins C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The add_system_to_stage panic message on StartupStage could be clearer
5 participants
@merelymyself @alice-i-cecile @djeedai @mockersf @NathanSWard