Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Remove unnecessary unsafe Send and Sync impl for WinitWindows on wasm. #5863

Closed
wants to merge 1 commit into from

Conversation

tim-blackbird
Copy link
Contributor

Objective

#503 added these.
I don't know what problem it solved, the PR doesn't say and the code didn't make it obvious to me.

Solution

AFAIK removing unsafe Send/Sync impls can't introduce unsoundness.
Yeet.

Migration Guide

Why tho.

@rparrett
Copy link
Contributor

rparrett commented Sep 2, 2022

It seems like these were made redundant with #4027

@mockersf mockersf added A-Windowing Platform-agnostic interface layer to run your app in O-Web Specific to web (WASM) builds labels Sep 2, 2022
@alice-i-cecile
Copy link
Member

bors r+

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Sep 2, 2022
bors bot pushed a commit that referenced this pull request Sep 2, 2022
…n wasm. (#5863)

# Objective

#503 added these.
I don't know what problem it solved, the PR doesn't say and the code didn't make it obvious to me.

## Solution

AFAIK removing unsafe `Send`/`Sync` impls can't introduce unsoundness.
Yeet.

## Migration Guide
Why tho.


Co-authored-by: devil-ira <justthecooldude@gmail.com>
@bors bors bot changed the title Remove unnecessary unsafe Send and Sync impl for WinitWindows on wasm. [Merged by Bors] - Remove unnecessary unsafe Send and Sync impl for WinitWindows on wasm. Sep 2, 2022
@bors bors bot closed this Sep 2, 2022
@tim-blackbird tim-blackbird deleted the yeet-unsafe branch October 21, 2022 15:09
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
…n wasm. (bevyengine#5863)

# Objective

bevyengine#503 added these.
I don't know what problem it solved, the PR doesn't say and the code didn't make it obvious to me.

## Solution

AFAIK removing unsafe `Send`/`Sync` impls can't introduce unsoundness.
Yeet.

## Migration Guide
Why tho.


Co-authored-by: devil-ira <justthecooldude@gmail.com>
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
…n wasm. (bevyengine#5863)

# Objective

bevyengine#503 added these.
I don't know what problem it solved, the PR doesn't say and the code didn't make it obvious to me.

## Solution

AFAIK removing unsafe `Send`/`Sync` impls can't introduce unsoundness.
Yeet.

## Migration Guide
Why tho.


Co-authored-by: devil-ira <justthecooldude@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Windowing Platform-agnostic interface layer to run your app in O-Web Specific to web (WASM) builds S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants