Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Move ambiguity detection into its own file #5918

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Move ambiguity detection into its own file #5918

wants to merge 4 commits into from

Conversation

alice-i-cecile
Copy link
Member

Objective

This code is very disjoint, and the stage.rs file that it's in is already very long.

All I've done is move the code and clean up the compiler errors that result.

Followup to #5916, split out from #4299.

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change labels Sep 8, 2022
afonsolage
afonsolage reviewed Sep 9, 2022
View reviewed changes
Copy link
Contributor

@afonsolage afonsolage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this PR is part of a bigger plan, does make sense to have all planned features in an tracking issue? So we may know what to expect in the future, like adding back the removed tests.

@alice-i-cecile
Copy link
Member Author

I'm working off the plan in #4299 (comment)

@alice-i-cecile
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Sep 9, 2022
@alice-i-cecile
Move ambiguity detection into its own file (#5918)
ca3fa9d 
# Objective

This code is very disjoint, and the `stage.rs` file that it's in is already very long.

All I've done is move the code and clean up the compiler errors that result.

Followup to #5916, split out from #4299.
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Sep 9, 2022
@alice-i-cecile
Copy link
Member Author

(merged with one approval due to triviality)

@bors
Copy link
Contributor

bors bot commented Sep 9, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Move ambiguity detection into its own file [Merged by Bors] - Move ambiguity detection into its own file Sep 9, 2022
@bors bors bot closed this Sep 9, 2022
nicopap pushed a commit to nicopap/bevy that referenced this pull request Sep 12, 2022
@alice-i-cecile @nicopap
Move ambiguity detection into its own file (bevyengine#5918)
492ceec 
# Objective

This code is very disjoint, and the `stage.rs` file that it's in is already very long.

All I've done is move the code and clean up the compiler errors that result.

Followup to bevyengine#5916, split out from bevyengine#4299.
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@alice-i-cecile @james7132
Move ambiguity detection into its own file (bevyengine#5918)
5962666 
# Objective

This code is very disjoint, and the `stage.rs` file that it's in is already very long.

All I've done is move the code and clean up the compiler errors that result.

Followup to bevyengine#5916, split out from bevyengine#4299.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@alice-i-cecile @ItsDoot
Move ambiguity detection into its own file (bevyengine#5918)
fd5d7c6 
# Objective

This code is very disjoint, and the `stage.rs` file that it's in is already very long.

All I've done is move the code and clean up the compiler errors that result.

Followup to bevyengine#5916, split out from bevyengine#4299.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsolage afonsolage afonsolage left review comments

@mockersf mockersf mockersf approved these changes

@maniwani maniwani Awaiting requested review from maniwani

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alice-i-cecile @afonsolage @mockersf