[Merged by Bors] - Reconfigure surface on present mode change #6049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Rendering
alice-i-cecile
approved these changes
Sep 21, 2022
rparrett
reviewed
Sep 21, 2022
rparrett
reviewed
Sep 21, 2022
examples/window/window_settings.rs
Outdated
Comment on lines
37
to
40
| info!( | ||
| "PRESENT_MODE: {:?}", | ||
| windows.get_primary().unwrap().present_mode() | ||
| ); |
There was a problem hiding this comment.
Suggested change
| info!( | |
| "PRESENT_MODE: {:?}", | |
| windows.get_primary().unwrap().present_mode() | |
| ); | |
| info!("PRESENT_MODE: {:?}", window.present_mode()); |
rparrett
approved these changes
Sep 21, 2022
rparrett
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 21, 2022
# Objective - Reconfigure surface after present mode changes. It seems that this is not done currently at runtime. It's pretty common for games to change such graphical settings at runtime. - Fixes present mode issue in #5111 ## Solution - Exactly like resolution change gets tracked when extracting window, do the same for present mode. Additionally, I added present mode (vsync) toggling to window settings example.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 19, 2022
# Objective - Reconfigure surface after present mode changes. It seems that this is not done currently at runtime. It's pretty common for games to change such graphical settings at runtime. - Fixes present mode issue in bevyengine#5111 ## Solution - Exactly like resolution change gets tracked when extracting window, do the same for present mode. Additionally, I added present mode (vsync) toggling to window settings example.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective - Reconfigure surface after present mode changes. It seems that this is not done currently at runtime. It's pretty common for games to change such graphical settings at runtime. - Fixes present mode issue in bevyengine#5111 ## Solution - Exactly like resolution change gets tracked when extracting window, do the same for present mode. Additionally, I added present mode (vsync) toggling to window settings example.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Reconfigure surface after present mode changes. It seems that this is not done currently at runtime. It's pretty common for games to change such graphical settings at runtime. - Fixes present mode issue in bevyengine#5111 ## Solution - Exactly like resolution change gets tracked when extracting window, do the same for present mode. Additionally, I added present mode (vsync) toggling to window settings example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Window.set_resolution()andset_present_mode()don't have expected side-effects #5111Solution
Additionally, I added present mode (vsync) toggling to window settings example.