[Merged by Bors] - add support for .comp glsl shaders #6084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceSentry
added
A-Rendering
jakobhellermann
approved these changes
Sep 24, 2022
There was a problem hiding this comment.
as precedent, glslang knows file extensions frag, vert, comp and stuff that wgpu doesn't expose: https://www.khronos.org/opengles/sdk/tools/Reference-Compiler/
|
@IceSentry this seems to be minimal support yet complete for the extension |
|
It was in draft mode because I haven't actually tested it with anything so I don't know if it works. As soon as I can confirm it works I'll take it out of draft mode. |
|
I tested a really simple compute shader using .comp and it worked as expected, so this is ready. |
mockersf
approved these changes
Sep 26, 2022
mockersf
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 27, 2022
# Objective - Support `.comp` extension for glsl compute shaders ## Solution - Add `.comp` to the shader asset loader
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 19, 2022
# Objective - Support `.comp` extension for glsl compute shaders ## Solution - Add `.comp` to the shader asset loader
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective - Support `.comp` extension for glsl compute shaders ## Solution - Add `.comp` to the shader asset loader
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Support `.comp` extension for glsl compute shaders ## Solution - Add `.comp` to the shader asset loader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
.compextension for glsl compute shadersSolution
.compto the shader asset loader