[Merged by Bors] - Impl Reflect for PathBuf and OsString #6193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Usability
|
@alice-i-cecile I added implementation for |
|
Great, thanks for the context there. Can you add that as a comment? |
|
Done! |
alice-i-cecile
approved these changes
Oct 7, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
tguichaoua
suggested changes
Oct 8, 2022
|
Of course, thanks, fixed. |
tguichaoua
approved these changes
Oct 8, 2022
MrGVSV
approved these changes
Oct 8, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 8, 2022
# Objective `Reflect` impl is missing for `PathBuf` and `OsString`. Closes #6166. ## Solution Add implementations. --- ## Changelog ### Added `Reflect` impls for `PathBuf` and `OsString`.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 19, 2022
# Objective `Reflect` impl is missing for `PathBuf` and `OsString`. Closes bevyengine#6166. ## Solution Add implementations. --- ## Changelog ### Added `Reflect` impls for `PathBuf` and `OsString`.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective `Reflect` impl is missing for `PathBuf` and `OsString`. Closes bevyengine#6166. ## Solution Add implementations. --- ## Changelog ### Added `Reflect` impls for `PathBuf` and `OsString`.
Pietrek14
pushed a commit
to Pietrek14/bevy
that referenced
this pull request
Dec 17, 2022
# Objective `Reflect` impl is missing for `PathBuf` and `OsString`. Closes bevyengine#6166. ## Solution Add implementations. --- ## Changelog ### Added `Reflect` impls for `PathBuf` and `OsString`.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective `Reflect` impl is missing for `PathBuf` and `OsString`. Closes bevyengine#6166. ## Solution Add implementations. --- ## Changelog ### Added `Reflect` impls for `PathBuf` and `OsString`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Reflectimpl is missing forPathBufandOsString. Closes #6166.Solution
Add implementations.
Changelog
Added
Reflectimpls forPathBufandOsString.