Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Make the default background color of NodeBundle transparent #6211

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Make the default background color of NodeBundle transparent #6211

wants to merge 2 commits into from

Conversation

TimJentzsch
Copy link
Contributor

Objective

Closes #6202.

The default background color for NodeBundle is currently white.
However, it's very rare that you actually want a white background color.
Instead, you often want a background color specific to the style of your game or a transparent background (e.g. for UI layout nodes).

Solution

Default is not derived for NodeBundle anymore, but explicitly specified.
The default background color is now transparent (Color::NONE.into()) as this is the most common use-case, is familiar from the web and makes specifying a layout for your UI less tedious.

Changelog

  • Changed the default NodeBundle.background_color to be transparent (Color::NONE.into()).

Migration Guide

If you want a NodeBundle with a white background color, you must explicitly specify it:

Before:

let node = NodeBundle {
    ..default()
}

After:

let node = NodeBundle {
    background_color: Color::WHITE.into(),
    ..default()
}

@mockersf mockersf added A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Oct 9, 2022
nicopap
nicopap approved these changes Oct 9, 2022
View reviewed changes
Copy link
Contributor

@nicopap nicopap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet no one will miss white being the default

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 9, 2022
@mockersf
Copy link
Member

mockersf commented Oct 9, 2022

bors r+

bors bot pushed a commit that referenced this pull request Oct 9, 2022
@TimJentzsch
Make the default background color of NodeBundle transparent (#6211)
1738527 
# Objective

Closes #6202.

The default background color for `NodeBundle` is currently white.
However, it's very rare that you actually want a white background color.
Instead, you often want a background color specific to the style of your game or a transparent background (e.g. for UI layout nodes).

## Solution

`Default` is not derived for `NodeBundle` anymore, but explicitly specified.
The default background color is now transparent (`Color::NONE.into()`) as this is the most common use-case, is familiar from the web and makes specifying a layout for your UI less tedious.

---

## Changelog

- Changed the default `NodeBundle.background_color` to be transparent (`Color::NONE.into()`).

## Migration Guide

If you want a `NodeBundle` with a white background color, you must explicitly specify it:

Before:

```rust
let node = NodeBundle {
    ..default()
}
```

After:

```rust
let node = NodeBundle {
    background_color: Color::WHITE.into(),
    ..default()
}
```
@bors
Copy link
Contributor

bors bot commented Oct 9, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Make the default background color of NodeBundle transparent [Merged by Bors] - Make the default background color of NodeBundle transparent Oct 9, 2022
@bors bors bot closed this Oct 9, 2022
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 19, 2022
@TimJentzsch @james7132
Make the default background color of NodeBundle transparent (bevyen…
4dcbfc8 
…gine#6211)

# Objective

Closes bevyengine#6202.

The default background color for `NodeBundle` is currently white.
However, it's very rare that you actually want a white background color.
Instead, you often want a background color specific to the style of your game or a transparent background (e.g. for UI layout nodes).

## Solution

`Default` is not derived for `NodeBundle` anymore, but explicitly specified.
The default background color is now transparent (`Color::NONE.into()`) as this is the most common use-case, is familiar from the web and makes specifying a layout for your UI less tedious.

---

## Changelog

- Changed the default `NodeBundle.background_color` to be transparent (`Color::NONE.into()`).

## Migration Guide

If you want a `NodeBundle` with a white background color, you must explicitly specify it:

Before:

```rust
let node = NodeBundle {
    ..default()
}
```

After:

```rust
let node = NodeBundle {
    background_color: Color::WHITE.into(),
    ..default()
}
```
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@TimJentzsch @james7132
Make the default background color of NodeBundle transparent (bevyen…
0628ac2 
…gine#6211)

# Objective

Closes bevyengine#6202.

The default background color for `NodeBundle` is currently white.
However, it's very rare that you actually want a white background color.
Instead, you often want a background color specific to the style of your game or a transparent background (e.g. for UI layout nodes).

## Solution

`Default` is not derived for `NodeBundle` anymore, but explicitly specified.
The default background color is now transparent (`Color::NONE.into()`) as this is the most common use-case, is familiar from the web and makes specifying a layout for your UI less tedious.

---

## Changelog

- Changed the default `NodeBundle.background_color` to be transparent (`Color::NONE.into()`).

## Migration Guide

If you want a `NodeBundle` with a white background color, you must explicitly specify it:

Before:

```rust
let node = NodeBundle {
    ..default()
}
```

After:

```rust
let node = NodeBundle {
    background_color: Color::WHITE.into(),
    ..default()
}
```
Pietrek14 pushed a commit to Pietrek14/bevy that referenced this pull request Dec 17, 2022
@TimJentzsch @Pietrek14
Make the default background color of NodeBundle transparent (bevyen…
f3bdba1 
…gine#6211)

# Objective

Closes bevyengine#6202.

The default background color for `NodeBundle` is currently white.
However, it's very rare that you actually want a white background color.
Instead, you often want a background color specific to the style of your game or a transparent background (e.g. for UI layout nodes).

## Solution

`Default` is not derived for `NodeBundle` anymore, but explicitly specified.
The default background color is now transparent (`Color::NONE.into()`) as this is the most common use-case, is familiar from the web and makes specifying a layout for your UI less tedious.

---

## Changelog

- Changed the default `NodeBundle.background_color` to be transparent (`Color::NONE.into()`).

## Migration Guide

If you want a `NodeBundle` with a white background color, you must explicitly specify it:

Before:

```rust
let node = NodeBundle {
    ..default()
}
```

After:

```rust
let node = NodeBundle {
    background_color: Color::WHITE.into(),
    ..default()
}
```
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@TimJentzsch @ItsDoot
Make the default background color of NodeBundle transparent (bevyen…
456665c 
…gine#6211)

# Objective

Closes bevyengine#6202.

The default background color for `NodeBundle` is currently white.
However, it's very rare that you actually want a white background color.
Instead, you often want a background color specific to the style of your game or a transparent background (e.g. for UI layout nodes).

## Solution

`Default` is not derived for `NodeBundle` anymore, but explicitly specified.
The default background color is now transparent (`Color::NONE.into()`) as this is the most common use-case, is familiar from the web and makes specifying a layout for your UI less tedious.

---

## Changelog

- Changed the default `NodeBundle.background_color` to be transparent (`Color::NONE.into()`).

## Migration Guide

If you want a `NodeBundle` with a white background color, you must explicitly specify it:

Before:

```rust
let node = NodeBundle {
    ..default()
}
```

After:

```rust
let node = NodeBundle {
    background_color: Color::WHITE.into(),
    ..default()
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicopap nicopap nicopap approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make default background color of UI NodeBundles transparent
4 participants
@TimJentzsch @mockersf @nicopap @alice-i-cecile