Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - migrate away from actions-rs actions to dtolnay/rust-toolchain #6432

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - migrate away from actions-rs actions to dtolnay/rust-toolchain #6432

wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

Objective

Solution

@alice-i-cecile alice-i-cecile added A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change labels Oct 31, 2022
This was referenced Oct 31, 2022
Closed
Closed
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 31, 2022
@alice-i-cecile
Copy link
Member

This basically halves our CI time.

Before: https://github.com/bevyengine/bevy/pull/6430/checks
After: https://github.com/bevyengine/bevy/pull/6432/checks

bors r+

bors bot pushed a commit that referenced this pull request Oct 31, 2022
@mockersf
migrate away from actions-rs actions to dtolnay/rust-toolchain (#6432)
89b3422 
# Objective

- actions from actions-rs are outdated and use deprecated function
- They haven't been updated for the last two years (https://github.com/actions-rs/toolchain)

## Solution

- use the newer and up-to-date https://github.com/dtolnay/rust-toolchain
@bors
Copy link
Contributor

bors bot commented Oct 31, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title migrate away from actions-rs actions to dtolnay/rust-toolchain [Merged by Bors] - migrate away from actions-rs actions to dtolnay/rust-toolchain Oct 31, 2022
@bors bors bot closed this Oct 31, 2022
@msvbg msvbg mentioned this pull request Nov 13, 2022
Merged
@Shatur Shatur mentioned this pull request Nov 14, 2022
Merged
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
migrate away from actions-rs actions to dtolnay/rust-toolchain (bevye…
a715e10 
…ngine#6432)

# Objective

- actions from actions-rs are outdated and use deprecated function
- They haven't been updated for the last two years (https://github.com/actions-rs/toolchain)

## Solution

- use the newer and up-to-date https://github.com/dtolnay/rust-toolchain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mockersf @alice-i-cecile