Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Document World::clear_trackers() #6520

Closed
wants to merge 1 commit into from

Conversation

djeedai
Copy link
Contributor

@djeedai djeedai commented Nov 8, 2022

Objective

Document World::clear_trackers().

Solution

Document the World::clear_trackers() method, and briefly how it's related to change detection and RemovedComponents.

This is a follow-up from this discussion on Discord.

Document the `World::clear_trackers()` method, and briefly how it's
related to change detection and `RemovedComponents`.
@djeedai djeedai added C-Docs An addition or correction to our documentation A-ECS Entities, components, systems, and events labels Nov 8, 2022
@djeedai
Copy link
Contributor Author

djeedai commented Nov 9, 2022

image

Copy link
Contributor

@Carter0 Carter0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 10, 2022
@djeedai
Copy link
Contributor Author

djeedai commented Dec 10, 2022

@mockersf there's some spurious CI failure, could you please re-run? Thanks!

@mockersf
Copy link
Member

Those have been fixed on main, and have no chance to be cause by this PR...
Also only you or Cart could rerun CI, I can just trigger bors, which you can also do 👍

@alice-i-cecile
Copy link
Member

Yep @djeedai you can run bors try yourself :)

bors try

bors bot added a commit that referenced this pull request Dec 11, 2022
@alice-i-cecile
Copy link
Member

bors r+

@djeedai
Copy link
Contributor Author

djeedai commented Dec 11, 2022

Those have been fixed on main, and have no chance to be cause by this PR... Also only you or Cart could rerun CI, I can just trigger bors, which you can also do 👍

Ack on bors thanks, I didn't think about it. On CI though I cannot rerun it, at least from mobile I don't see any option. Although with bors I realize I don't need it.

bors bot pushed a commit that referenced this pull request Dec 11, 2022
# Objective

Document `World::clear_trackers()`.

## Solution

Document the `World::clear_trackers()` method, and briefly how it's related to change detection and `RemovedComponents`.

This is a follow-up from [this discussion](https://discord.com/channels/691052431525675048/749335865876021248/1039628807025479700) on Discord.
@bors bors bot changed the title Document World::clear_trackers() [Merged by Bors] - Document World::clear_trackers() Dec 11, 2022
@bors bors bot closed this Dec 11, 2022
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
# Objective

Document `World::clear_trackers()`.

## Solution

Document the `World::clear_trackers()` method, and briefly how it's related to change detection and `RemovedComponents`.

This is a follow-up from [this discussion](https://discord.com/channels/691052431525675048/749335865876021248/1039628807025479700) on Discord.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

Document `World::clear_trackers()`.

## Solution

Document the `World::clear_trackers()` method, and briefly how it's related to change detection and `RemovedComponents`.

This is a follow-up from [this discussion](https://discord.com/channels/691052431525675048/749335865876021248/1039628807025479700) on Discord.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants