Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Make Core Pipeline Graph Nodes Public #6605

Closed
wants to merge 5 commits into from

Conversation

cryscan
Copy link
Contributor

@cryscan cryscan commented Nov 14, 2022

Objective

Make core pipeline graphic nodes, including BloomNode, FxaaNode, TonemappingNode and UpscalingNode public.
This will allow users to construct their own render graphs with these build-in nodes.

Solution

Make them public.
Also put node names into bevy's core namespace (core_2d::graph::node, core_3d::graph::node) which makes them consistent.

@james7132 james7132 added A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Nov 14, 2022
Comment on lines -178 to +165
const IN_VIEW: &'static str = "view";
pub const IN_VIEW: &'static str = "view";
Copy link
Member

@mockersf mockersf Nov 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is going to be public and reused, should it have a more unique value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is in the scope of this PR, currently other core nodes all have the same input slot name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense that the input slots have the same name if they serve the same purpose for their respective nodes.

@cart cart added this to the 0.9.1 milestone Nov 16, 2022
@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 17, 2022
@cart
Copy link
Member

cart commented Nov 18, 2022

bors r+

bors bot pushed a commit that referenced this pull request Nov 18, 2022
# Objective

Make core pipeline graphic nodes, including `BloomNode`, `FxaaNode`, `TonemappingNode` and `UpscalingNode` public.
This will allow users to construct their own render graphs with these build-in nodes.

## Solution

Make them public.
Also put node names into bevy's core namespace (`core_2d::graph::node`, `core_3d::graph::node`) which makes them consistent.
@bors bors bot changed the title Make Core Pipeline Graph Nodes Public [Merged by Bors] - Make Core Pipeline Graph Nodes Public Nov 18, 2022
@bors bors bot closed this Nov 18, 2022
cart pushed a commit that referenced this pull request Nov 30, 2022
# Objective

Make core pipeline graphic nodes, including `BloomNode`, `FxaaNode`, `TonemappingNode` and `UpscalingNode` public.
This will allow users to construct their own render graphs with these build-in nodes.

## Solution

Make them public.
Also put node names into bevy's core namespace (`core_2d::graph::node`, `core_3d::graph::node`) which makes them consistent.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

Make core pipeline graphic nodes, including `BloomNode`, `FxaaNode`, `TonemappingNode` and `UpscalingNode` public.
This will allow users to construct their own render graphs with these build-in nodes.

## Solution

Make them public.
Also put node names into bevy's core namespace (`core_2d::graph::node`, `core_3d::graph::node`) which makes them consistent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants