[Merged by Bors] - Don't kill contributors on window squish #6675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Nov 18, 2022
mockersf
approved these changes
Nov 18, 2022
Pietrek14
approved these changes
Nov 18, 2022
mockersf
added
the
S-Ready-For-Final-Review
tim-blackbird
approved these changes
Nov 18, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 18, 2022
# Objective - The `contributors` example panics when attempting to generate an empty range if the window height is smaller than the sprites - Don't do that ## Solution - Clamp the bounce height to be 0 minimum, and generate an inclusive range when passing it to `rng.gen_range`
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
taiyoungjang
pushed a commit
to taiyoungjang/bevy
that referenced
this pull request
Dec 15, 2022
# Objective - The `contributors` example panics when attempting to generate an empty range if the window height is smaller than the sprites - Don't do that ## Solution - Clamp the bounce height to be 0 minimum, and generate an inclusive range when passing it to `rng.gen_range`
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
# Objective - The `contributors` example panics when attempting to generate an empty range if the window height is smaller than the sprites - Don't do that ## Solution - Clamp the bounce height to be 0 minimum, and generate an inclusive range when passing it to `rng.gen_range`
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - The `contributors` example panics when attempting to generate an empty range if the window height is smaller than the sprites - Don't do that ## Solution - Clamp the bounce height to be 0 minimum, and generate an inclusive range when passing it to `rng.gen_range`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
contributorsexample panics when attempting to generate an empty range if the window height is smaller than the spritesSolution
rng.gen_range