[Merged by Bors] - Move Android example to its own package #6759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
P-Critical
alice-i-cecile
approved these changes
Nov 25, 2022
james7132
approved these changes
Nov 25, 2022
james7132
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 25, 2022
# Objective - Fix CI issue with updated `cargo-app` ## Solution - Move the Android example to its own package. It's not necessary for the CI fix, but it's cleaner, mimic the iOS example, and easier to reuse for someone wanting to setup android support in their project - Build the package in CI instead of the example The Android example is still working on my android device with this change 👍
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
cart
pushed a commit
that referenced
this pull request
Dec 1, 2022
# Objective - Fix CI issue with updated `cargo-app` ## Solution - Move the Android example to its own package. It's not necessary for the CI fix, but it's cleaner, mimic the iOS example, and easier to reuse for someone wanting to setup android support in their project - Build the package in CI instead of the example The Android example is still working on my android device with this change 👍
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Fix CI issue with updated `cargo-app` ## Solution - Move the Android example to its own package. It's not necessary for the CI fix, but it's cleaner, mimic the iOS example, and easier to reuse for someone wanting to setup android support in their project - Build the package in CI instead of the example The Android example is still working on my android device with this change 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
cargo-appSolution
The Android example is still working on my android device with this change 👍