Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Remove TextError::ExceedMaxTextAtlases(usize) variant #6796

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Remove TextError::ExceedMaxTextAtlases(usize) variant #6796

wants to merge 1 commit into from

Conversation

JayPavlina
Copy link
Contributor

Objective

Fixes #6756

Solution

Removes the variant wherever it's used

@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-UI Graphical user interfaces, styles, layouts, and widgets labels Nov 29, 2022
@alice-i-cecile
Copy link
Member

Thanks :)

@james7132 james7132 added the M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Nov 29, 2022
@james7132 james7132 added this to the 0.10 milestone Nov 29, 2022
@cart
Copy link
Member

cart commented Dec 5, 2022

bors r+

bors bot pushed a commit that referenced this pull request Dec 5, 2022
@JayPavlina
Remove TextError::ExceedMaxTextAtlases(usize) variant (#6796)
e621acd 
# Objective

Fixes #6756

## Solution

Removes the variant wherever it's used

Co-authored-by: Jay Pavlina <jay@enjin.io>
@bors
Copy link
Contributor

bors bot commented Dec 5, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Remove TextError::ExceedMaxTextAtlases(usize) variant [Merged by Bors] - Remove TextError::ExceedMaxTextAtlases(usize) variant Dec 5, 2022
@bors bors bot closed this Dec 5, 2022
ickshonpe pushed a commit to ickshonpe/bevy that referenced this pull request Dec 6, 2022
@JayPavlina @ickshonpe
Remove TextError::ExceedMaxTextAtlases(usize) variant (bevyengine#6796
32c015c 
)

# Objective

Fixes bevyengine#6756

## Solution

Removes the variant wherever it's used

Co-authored-by: Jay Pavlina <jay@enjin.io>
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@JayPavlina @alradish
Remove TextError::ExceedMaxTextAtlases(usize) variant (bevyengine#6796
c94c213 
)

# Objective

Fixes bevyengine#6756

## Solution

Removes the variant wherever it's used

Co-authored-by: Jay Pavlina <jay@enjin.io>
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@JayPavlina @ItsDoot
Remove TextError::ExceedMaxTextAtlases(usize) variant (bevyengine#6796
799012c 
)

# Objective

Fixes bevyengine#6756

## Solution

Removes the variant wherever it's used

Co-authored-by: Jay Pavlina <jay@enjin.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.

Remove TextError::ExceedMaxTextAtlases(usize) variant
4 participants
@JayPavlina @alice-i-cecile @cart @james7132