Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Mention search filters in CONTRIBUTING.md #6804

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - Mention search filters in CONTRIBUTING.md #6804

wants to merge 5 commits into from

Conversation

Ptipiak
Copy link
Contributor

@Ptipiak Ptipiak commented Nov 30, 2022 •
edited
Loading

  • Adding a new section concerning the maintainers of the repo

Objective

Solution

  • Modifying CONTRIBUTING.md
  • Adding a new section dedicated to maintainers in CONTRIBUTING.md

@Ptipiak
Metion search filters in CONTRIBUTING.md
4410dc2 
* Adding a new section concerning the maintainers of the repo
@Ptipiak Ptipiak changed the title Metion search filters in CONTRIBUTING.md Mention search filters in CONTRIBUTING.md Nov 30, 2022
@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Meta About the project itself labels Nov 30, 2022
alice-i-cecile
alice-i-cecile reviewed Nov 30, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
alice-i-cecile
alice-i-cecile requested changes Nov 30, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this :) Just needs a bit of wording help down below.

alice-i-cecile
alice-i-cecile reviewed Nov 30, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
alice-i-cecile
alice-i-cecile reviewed Nov 30, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
alice-i-cecile
alice-i-cecile reviewed Nov 30, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
alice-i-cecile
alice-i-cecile requested changes Nov 30, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely better than before. I left some more wording suggestions for you: I think that this information is useful for everyone to be able to see, not just maintainers.

@Ptipiak @alice-i-cecile
Apply suggestions from code review
c0a836a 
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Nilirad
Nilirad approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@Nilirad Nilirad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe reference-style links may help plain text legibility but that's just a personal preference.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 1, 2022
@alice-i-cecile
Copy link
Member

Thanks!

bors r+

bors bot pushed a commit that referenced this pull request Dec 1, 2022
@Ptipiak
Mention search filters in CONTRIBUTING.md (#6804)
f1ee2de 
* Adding a new section concerning the maintainers of the repo

# Objective

- Adding a few helpful links in the CONTRIBUTING.md files
- Fixes #6221 

## Solution

- Modifying CONTRIBUTING.md
- Adding a new section dedicated to maintainers  in CONTRIBUTING.md

---


Co-authored-by: Ptipiak <Ptipiak.off@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 1, 2022

Build failed:

mockersf
mockersf reviewed Dec 1, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Ptipiak @mockersf
Fixing the linting issues
cdf4af4 
Co-authored-by: François <mockersf@gmail.com>
@Ptipiak
Copy link
Contributor Author

Ptipiak commented Dec 1, 2022

Thanks, for some reason my markdownlint wasn't picking the extra white space locally

@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Dec 1, 2022
@Ptipiak
Mention search filters in CONTRIBUTING.md (#6804)
cf48b0d 
* Adding a new section concerning the maintainers of the repo

# Objective

- Adding a few helpful links in the CONTRIBUTING.md files
- Fixes #6221 

## Solution

- Modifying CONTRIBUTING.md
- Adding a new section dedicated to maintainers  in CONTRIBUTING.md

---


Co-authored-by: Ptipiak <Ptipiak.off@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 1, 2022

Build failed:

mockersf
mockersf reviewed Dec 1, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Ptipiak @mockersf
Apply suggestions from code review
928720c 
Co-authored-by: François <mockersf@gmail.com>
alice-i-cecile
alice-i-cecile approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors retry

bors bot pushed a commit that referenced this pull request Dec 2, 2022
@Ptipiak
Mention search filters in CONTRIBUTING.md (#6804)
9191880 
* Adding a new section concerning the maintainers of the repo

# Objective

- Adding a few helpful links in the CONTRIBUTING.md files
- Fixes #6221 

## Solution

- Modifying CONTRIBUTING.md
- Adding a new section dedicated to maintainers  in CONTRIBUTING.md

---


Co-authored-by: Ptipiak <Ptipiak.off@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 2, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Mention search filters in CONTRIBUTING.md [Merged by Bors] - Mention search filters in CONTRIBUTING.md Dec 2, 2022
@bors bors bot closed this Dec 2, 2022
@james7132 james7132 added this to the 0.10 milestone Dec 6, 2022
ickshonpe pushed a commit to ickshonpe/bevy that referenced this pull request Dec 6, 2022
@Ptipiak @ickshonpe
Mention search filters in CONTRIBUTING.md (bevyengine#6804)
81043ab 
* Adding a new section concerning the maintainers of the repo

# Objective

- Adding a few helpful links in the CONTRIBUTING.md files
- Fixes bevyengine#6221 

## Solution

- Modifying CONTRIBUTING.md
- Adding a new section dedicated to maintainers  in CONTRIBUTING.md

---


Co-authored-by: Ptipiak <Ptipiak.off@gmail.com>
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@Ptipiak @alradish
Mention search filters in CONTRIBUTING.md (bevyengine#6804)
62acb5b 
* Adding a new section concerning the maintainers of the repo

# Objective

- Adding a few helpful links in the CONTRIBUTING.md files
- Fixes bevyengine#6221 

## Solution

- Modifying CONTRIBUTING.md
- Adding a new section dedicated to maintainers  in CONTRIBUTING.md

---


Co-authored-by: Ptipiak <Ptipiak.off@gmail.com>
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@Ptipiak @ItsDoot
Mention search filters in CONTRIBUTING.md (bevyengine#6804)
90ae92d 
* Adding a new section concerning the maintainers of the repo

# Objective

- Adding a few helpful links in the CONTRIBUTING.md files
- Fixes bevyengine#6221 

## Solution

- Modifying CONTRIBUTING.md
- Adding a new section dedicated to maintainers  in CONTRIBUTING.md

---


Co-authored-by: Ptipiak <Ptipiak.off@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf left review comments

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@Nilirad Nilirad Nilirad approved these changes

Assignees
No one assigned
Labels
A-Meta About the project itself C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.

Add useful search filters to CONTRIBUTING.md
5 participants
@Ptipiak @alice-i-cecile @mockersf @Nilirad @james7132