Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - docs: Use correct cargo-flamegraph upstream repo URL #6873

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - docs: Use correct cargo-flamegraph upstream repo URL #6873

wants to merge 1 commit into from

Conversation

oliviacrain
Copy link
Contributor

Objective

Links to cargo-flamegraph's repo point to a fork, not the actual upstream repo. We should point to the source of truth instead of a fork that hasn't been updated since 2019.

Solution

Change links to point to the upstream repo at flamegraph-rs/flamegraph.

@james7132 james7132 added C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Dec 6, 2022
@mockersf
Copy link
Member

mockersf commented Dec 7, 2022

bors r+

bors bot pushed a commit that referenced this pull request Dec 7, 2022
# Objective

Links to `cargo-flamegraph`'s repo point to a [fork](https://github.com/killercup/cargo-flamegraph), not the actual upstream repo. We should point to the source of truth instead of a fork that hasn't been updated since 2019.

## Solution

Change links to point to the upstream repo at  [flamegraph-rs/flamegraph](https://github.com/flamegraph-rs/flamegraph).
@bors bors bot changed the title docs: Use correct cargo-flamegraph upstream repo URL [Merged by Bors] - docs: Use correct cargo-flamegraph upstream repo URL Dec 7, 2022
@bors bors bot closed this Dec 7, 2022
@james7132 james7132 added this to the 0.10 milestone Dec 7, 2022
@oliviacrain oliviacrain deleted the flamegraph-upstream branch December 8, 2022 18:22
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
# Objective

Links to `cargo-flamegraph`'s repo point to a [fork](https://github.com/killercup/cargo-flamegraph), not the actual upstream repo. We should point to the source of truth instead of a fork that hasn't been updated since 2019.

## Solution

Change links to point to the upstream repo at  [flamegraph-rs/flamegraph](https://github.com/flamegraph-rs/flamegraph).
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

Links to `cargo-flamegraph`'s repo point to a [fork](https://github.com/killercup/cargo-flamegraph), not the actual upstream repo. We should point to the source of truth instead of a fork that hasn't been updated since 2019.

## Solution

Change links to point to the upstream repo at  [flamegraph-rs/flamegraph](https://github.com/flamegraph-rs/flamegraph).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants