Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add a stress test profile #6901

Closed
wants to merge 7 commits into from

Conversation

james7132
Copy link
Member

Objective

This adds a custom profile for testing against stress tests. Bevy seemingly gets notably faster with LTO turned on. To more accurately depict production level performance, LTO and other rustc-level optimizations should be enabled when performance testing on stress tests.

Also updated the stress test docs to reflect that users should be using it.

@james7132 james7132 added A-Animation Make things move and change over time C-Performance A change motivated by improving speed, memory usage or compile times A-Meta About the project itself A-Diagnostics Logging, crash handling, error reporting and performance analysis and removed A-Animation Make things move and change over time labels Dec 9, 2022
Cargo.toml Outdated Show resolved Hide resolved
Co-authored-by: ira <JustTheCoolDude@gmail.com>
Cargo.toml Outdated Show resolved Hide resolved
james7132 and others added 2 commits December 11, 2022 18:17
Co-authored-by: ira <JustTheCoolDude@gmail.com>
Co-authored-by: François <mockersf@gmail.com>
@james7132 james7132 requested review from mockersf and tim-blackbird and removed request for tim-blackbird December 12, 2022 02:18
@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 12, 2022
@alice-i-cecile
Copy link
Member

@james7132 once mdlint failures are fixed I'll merge this in.

@james7132
Copy link
Member Author

@alice-i-cecile done!

@james7132 james7132 added this to the 0.10 milestone Dec 14, 2022
@mockersf
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Dec 20, 2022
# Objective
This adds a custom profile for testing against stress tests. Bevy seemingly gets notably faster with LTO turned on. To more accurately depict production level performance, LTO and other rustc-level optimizations should be enabled when performance testing on stress tests.

Also updated the stress test docs to reflect that users should be using it.
@bors
Copy link
Contributor

bors bot commented Dec 20, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Dec 20, 2022
# Objective
This adds a custom profile for testing against stress tests. Bevy seemingly gets notably faster with LTO turned on. To more accurately depict production level performance, LTO and other rustc-level optimizations should be enabled when performance testing on stress tests.

Also updated the stress test docs to reflect that users should be using it.
@bors
Copy link
Contributor

bors bot commented Dec 20, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Dec 20, 2022
# Objective
This adds a custom profile for testing against stress tests. Bevy seemingly gets notably faster with LTO turned on. To more accurately depict production level performance, LTO and other rustc-level optimizations should be enabled when performance testing on stress tests.

Also updated the stress test docs to reflect that users should be using it.
@bors
Copy link
Contributor

bors bot commented Dec 20, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Dec 20, 2022
# Objective
This adds a custom profile for testing against stress tests. Bevy seemingly gets notably faster with LTO turned on. To more accurately depict production level performance, LTO and other rustc-level optimizations should be enabled when performance testing on stress tests.

Also updated the stress test docs to reflect that users should be using it.
@bors
Copy link
Contributor

bors bot commented Dec 20, 2022

Build failed:

@james7132
Copy link
Member Author

bors retry

bors bot pushed a commit that referenced this pull request Dec 20, 2022
# Objective
This adds a custom profile for testing against stress tests. Bevy seemingly gets notably faster with LTO turned on. To more accurately depict production level performance, LTO and other rustc-level optimizations should be enabled when performance testing on stress tests.

Also updated the stress test docs to reflect that users should be using it.
@bors bors bot changed the title Add a stress test profile [Merged by Bors] - Add a stress test profile Dec 20, 2022
@bors bors bot closed this Dec 20, 2022
@james7132 james7132 deleted the stress-test-profile branch January 20, 2023 01:13
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
# Objective
This adds a custom profile for testing against stress tests. Bevy seemingly gets notably faster with LTO turned on. To more accurately depict production level performance, LTO and other rustc-level optimizations should be enabled when performance testing on stress tests.

Also updated the stress test docs to reflect that users should be using it.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective
This adds a custom profile for testing against stress tests. Bevy seemingly gets notably faster with LTO turned on. To more accurately depict production level performance, LTO and other rustc-level optimizations should be enabled when performance testing on stress tests.

Also updated the stress test docs to reflect that users should be using it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Diagnostics Logging, crash handling, error reporting and performance analysis A-Meta About the project itself C-Performance A change motivated by improving speed, memory usage or compile times S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants