Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Document undocumented features of AsBindGroup derive #6910

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Document undocumented features of AsBindGroup derive #6910

wants to merge 1 commit into from

Conversation

IceSentry
Copy link
Contributor

@IceSentry IceSentry commented Dec 10, 2022 •
edited
Loading

Objective

Solution

  • Document the new arguments in the doc block for the derive.

@IceSentry IceSentry added C-Docs An addition or correction to our documentation C-Feature A new feature, making something new possible A-Rendering Drawing game state to the screen and removed C-Feature A new feature, making something new possible labels Dec 10, 2022
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 11, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Dec 11, 2022
@IceSentry
Document undocumented features of AsBindGroup derive (#6910)
3669176 
# Objective

- #5364 Added a few features to the AsBindGroup derive, but if you don't know they exist they aren't documented anywhere.


## Solution

- Document the new arguments in the doc block for the derive.
@bors
Copy link
Contributor

bors bot commented Dec 11, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Document undocumented features of AsBindGroup derive [Merged by Bors] - Document undocumented features of AsBindGroup derive Dec 11, 2022
@bors bors bot closed this Dec 11, 2022
@IceSentry IceSentry mentioned this pull request Dec 12, 2022
Closed
@IceSentry IceSentry deleted the asbindgroup-docs branch December 12, 2022 09:12
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@IceSentry @alradish
Document undocumented features of AsBindGroup derive (bevyengine#6910)
941f6e0 
# Objective

- bevyengine#5364 Added a few features to the AsBindGroup derive, but if you don't know they exist they aren't documented anywhere.


## Solution

- Document the new arguments in the doc block for the derive.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@IceSentry @ItsDoot
Document undocumented features of AsBindGroup derive (bevyengine#6910)
522bfc3 
# Objective

- bevyengine#5364 Added a few features to the AsBindGroup derive, but if you don't know they exist they aren't documented anywhere.


## Solution

- Document the new arguments in the doc block for the derive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IceSentry @alice-i-cecile @tim-blackbird