[Merged by Bors] - Fix clippy lints and failed test with Rust 1.66 #6945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Build-System
alice-i-cecile
approved these changes
Dec 13, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
Dec 13, 2022
|
bors try |
|
Bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 15, 2022
# Objective [Rust 1.66](https://blog.rust-lang.org/inside-rust/2022/12/12/1.66.0-prerelease.html) is coming in a few days, and bevy doesn't build with it. Fix that. ## Solution Replace output from a trybuild test, and fix a few new instances of `needless_borrow` and `unnecessary_cast` that are now caught. ## Note Due to the trybuild test, this can't be merged until 1.66 is released.
bors
bot
changed the title
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Dec 16, 2022
# Objective [Rust 1.66](https://blog.rust-lang.org/inside-rust/2022/12/12/1.66.0-prerelease.html) is coming in a few days, and bevy doesn't build with it. Fix that. ## Solution Replace output from a trybuild test, and fix a few new instances of `needless_borrow` and `unnecessary_cast` that are now caught. ## Note Due to the trybuild test, this can't be merged until 1.66 is released.
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
# Objective [Rust 1.66](https://blog.rust-lang.org/inside-rust/2022/12/12/1.66.0-prerelease.html) is coming in a few days, and bevy doesn't build with it. Fix that. ## Solution Replace output from a trybuild test, and fix a few new instances of `needless_borrow` and `unnecessary_cast` that are now caught. ## Note Due to the trybuild test, this can't be merged until 1.66 is released.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective [Rust 1.66](https://blog.rust-lang.org/inside-rust/2022/12/12/1.66.0-prerelease.html) is coming in a few days, and bevy doesn't build with it. Fix that. ## Solution Replace output from a trybuild test, and fix a few new instances of `needless_borrow` and `unnecessary_cast` that are now caught. ## Note Due to the trybuild test, this can't be merged until 1.66 is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Rust 1.66 is coming in a few days, and bevy doesn't build with it.
Fix that.
Solution
Replace output from a trybuild test, and fix a few new instances of
needless_borrowandunnecessary_castthat are now caught.Note
Due to the trybuild test, this can't be merged until 1.66 is released.