Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add a const PipeSystem constructor #7019

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - Add a const PipeSystem constructor #7019

wants to merge 5 commits into from

Conversation

JoJoJet
Copy link
Member

@JoJoJet JoJoJet commented Dec 24, 2022

Objective

Fix #5914.

PipeSystem cannot be constructed in const contexts.

Solution

Add a const PipeSystem::new function.

@JoJoJet JoJoJet added C-Feature A new feature, making something new possible A-ECS Entities, components, systems, and events labels Dec 24, 2022
@harudagondi harudagondi added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 24, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Dec 25, 2022
@JoJoJet
Add a const PipeSystem constructor (#7019)
367cc8e 
# Objective

Fix #5914.

`PipeSystem` cannot be constructed in `const` contexts.

## Solution

Add a const `PipeSystem::new` function.
@bors
Copy link
Contributor

bors bot commented Dec 25, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Dec 25, 2022
@JoJoJet
Add a const PipeSystem constructor (#7019)
48b4a45 
# Objective

Fix #5914.

`PipeSystem` cannot be constructed in `const` contexts.

## Solution

Add a const `PipeSystem::new` function.
@bors
Copy link
Contributor

bors bot commented Dec 25, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add a const PipeSystem constructor [Merged by Bors] - Add a const PipeSystem constructor Dec 25, 2022
@bors bors bot closed this Dec 25, 2022
@JoJoJet JoJoJet deleted the new-pipe-system branch January 13, 2023 02:30
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@JoJoJet @alradish
Add a const PipeSystem constructor (bevyengine#7019)
7bb0400 
# Objective

Fix bevyengine#5914.

`PipeSystem` cannot be constructed in `const` contexts.

## Solution

Add a const `PipeSystem::new` function.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@JoJoJet @ItsDoot
Add a const PipeSystem constructor (bevyengine#7019)
b9e37dd 
# Objective

Fix bevyengine#5914.

`PipeSystem` cannot be constructed in `const` contexts.

## Solution

Add a const `PipeSystem::new` function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CGMossa CGMossa CGMossa approved these changes

@james7132 james7132 james7132 approved these changes

@harudagondi harudagondi harudagondi approved these changes

@nicopap nicopap nicopap approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a const constructor for ChainSystem
6 participants
@JoJoJet @alice-i-cecile @CGMossa @james7132 @harudagondi @nicopap