Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix ndk-macro link #7027

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix ndk-macro link #7027

wants to merge 1 commit into from

Conversation

jinleili
Copy link
Contributor

Objective

ndk-glue has been split from android-ndk-rs into a separate repository.

james7132
james7132 approved these changes Dec 25, 2022
View reviewed changes
Copy link
Member

@james7132 james7132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but https://github.com/rust-mobile/ndk-glue looks to be archived and marked unmaintained. We should probably look at the proposed alternative.

@james7132 james7132 added C-Docs An addition or correction to our documentation C-Code-Quality A section of code that is hard to understand or change O-Android Specific to the Android mobile operating system labels Dec 25, 2022
@alice-i-cecile alice-i-cecile mentioned this pull request Dec 25, 2022
Closed
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Dec 25, 2022
@jinleili
Fix ndk-macro link (#7027)
b6066c3 
# Objective

[ndk-glue](https://github.com/rust-mobile/ndk-glue)  has been split from `android-ndk-rs` into a separate repository.
@bors
Copy link
Contributor

bors bot commented Dec 25, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix ndk-macro link [Merged by Bors] - Fix ndk-macro link Dec 25, 2022
@bors bors bot closed this Dec 25, 2022
@jinleili jinleili deleted the ndk-glue-link branch December 25, 2022 09:15
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@jinleili @alradish
Fix ndk-macro link (bevyengine#7027)
3029cca 
# Objective

[ndk-glue](https://github.com/rust-mobile/ndk-glue)  has been split from `android-ndk-rs` into a separate repository.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@jinleili @ItsDoot
Fix ndk-macro link (bevyengine#7027)
65a5d6b 
# Objective

[ndk-glue](https://github.com/rust-mobile/ndk-glue)  has been split from `android-ndk-rs` into a separate repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
C-Code-Quality A section of code that is hard to understand or change C-Docs An addition or correction to our documentation O-Android Specific to the Android mobile operating system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jinleili @alice-i-cecile @james7132