[Merged by Bors] - Allow SystemParams with private fields
#7056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoJoJet
added
C-Bug
alice-i-cecile
approved these changes
Dec 29, 2022
There was a problem hiding this comment.
Wow, that's impressively simple. This will be incredibly useful for folks looking to make index-like data structures (#4513).
tim-blackbird
approved these changes
Dec 30, 2022
JoJoJet
added
the
S-Ready-For-Final-Review
CGMossa
approved these changes
Dec 30, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 4, 2023
# Objective - Fix #4200 Currently, `#[derive(SystemParam)]` publicly exposes each field type, which makes it impossible to encapsulate private fields. ## Solution Previously, the fields were leaked because they were used as an input generic type to the macro-generated `SystemParam::State` struct. That type has been changed to store its state in a field with a specific type, instead of a generic type. --- ## Changelog - Fixed a bug that caused `#[derive(SystemParam)]` to leak the types of private fields.
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
SystemParams with private fieldsSystemParams with private fields
4 tasks
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
# Objective - Fix bevyengine#4200 Currently, `#[derive(SystemParam)]` publicly exposes each field type, which makes it impossible to encapsulate private fields. ## Solution Previously, the fields were leaked because they were used as an input generic type to the macro-generated `SystemParam::State` struct. That type has been changed to store its state in a field with a specific type, instead of a generic type. --- ## Changelog - Fixed a bug that caused `#[derive(SystemParam)]` to leak the types of private fields.
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
# Objective - Fix bevyengine#7103. - The issue is caused because I forgot to add a where clause to a generated struct in bevyengine#7056. ## Solution - Add the where clause.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Fix bevyengine#4200 Currently, `#[derive(SystemParam)]` publicly exposes each field type, which makes it impossible to encapsulate private fields. ## Solution Previously, the fields were leaked because they were used as an input generic type to the macro-generated `SystemParam::State` struct. That type has been changed to store its state in a field with a specific type, instead of a generic type. --- ## Changelog - Fixed a bug that caused `#[derive(SystemParam)]` to leak the types of private fields.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Fix bevyengine#7103. - The issue is caused because I forgot to add a where clause to a generated struct in bevyengine#7056. ## Solution - Add the where clause.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Currently,
#[derive(SystemParam)]publicly exposes each field type, which makes it impossible to encapsulate private fields.Solution
Previously, the fields were leaked because they were used as an input generic type to the macro-generated
SystemParam::Statestruct. That type has been changed to store its state in a field with a specific type, instead of a generic type.Changelog
#[derive(SystemParam)]to leak the types of private fields.