Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Expose transform propagate systems #7145

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crates/bevy_transform/src/components/global_transform.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ use bevy_reflect::{std_traits::ReflectDefault, FromReflect, Reflect};
/// update the [`Transform`] of an entity in this stage or after, you will notice a 1 frame lag
/// before the [`GlobalTransform`] is updated.
///
/// Third party plugin should use [`transform_propagate_system_set`](crate::transform_propagate_system_set)
lewiszlw marked this conversation as resolved.
Show resolved Hide resolved
/// for complete transform propagation
lewiszlw marked this conversation as resolved.
Show resolved Hide resolved
///
/// # Examples
///
/// - [`transform`]
Expand Down
7 changes: 7 additions & 0 deletions crates/bevy_transform/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,13 @@ pub enum TransformSystem {
TransformPropagate,
}

/// Transform propagation system set for third party plugins use
pub fn transform_propagate_system_set() -> SystemSet {
SystemSet::new()
.with_system(systems::sync_simple_transforms)
.with_system(systems::propagate_transforms)
}

/// The base plugin for handling [`Transform`] components
#[derive(Default)]
pub struct TransformPlugin;
Expand Down
6 changes: 6 additions & 0 deletions crates/bevy_transform/src/systems.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ use bevy_ecs::prelude::{Changed, Entity, Query, With, Without};
use bevy_hierarchy::{Children, Parent};

/// Update [`GlobalTransform`] component of entities that aren't in the hierarchy
///
/// Third party plugin should use [`transform_propagate_system_set`](crate::transform_propagate_system_set)
lewiszlw marked this conversation as resolved.
Show resolved Hide resolved
/// for complete transform propagation
lewiszlw marked this conversation as resolved.
Show resolved Hide resolved
pub fn sync_simple_transforms(
mut query: Query<
(&Transform, &mut GlobalTransform),
Expand All @@ -16,6 +19,9 @@ pub fn sync_simple_transforms(

/// Update [`GlobalTransform`] component of entities based on entity hierarchy and
/// [`Transform`] component.
///
/// Third party plugin should use [`transform_propagate_system_set`](crate::transform_propagate_system_set)
lewiszlw marked this conversation as resolved.
Show resolved Hide resolved
/// for complete transform propagation
lewiszlw marked this conversation as resolved.
Show resolved Hide resolved
pub fn propagate_transforms(
mut root_query: Query<
(
Expand Down