Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Remove QueuedText #7414

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Remove QueuedText #7414

wants to merge 1 commit into from

Conversation

ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Jan 29, 2023 •
edited
Loading

Objective

Remove QueuedText.

QueuedText isn't useful. It's exposed in the bevy_ui public interface but can't be used for anything because its entities field is private.

Solution

Remove the QueuedText struct and use a Local<Vec<Entity> in its place.

Changelog

  • Removed QueuedText

@ickshonpe
changes:
eb482ed 
    * Removed the QueuedText struct
    * Renamed queued_text to queued_text_ids and changed it into a `Local<Vec<Entity>>`
@james7132 james7132 added A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Jan 29, 2023
@james7132
Copy link
Member

This is a breaking change as it alters the public interface. Can you put a changelog and migration guide section in the PR description?

alice-i-cecile
alice-i-cecile approved these changes Jan 29, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree: this is a leaked implementation detail.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 29, 2023
@alice-i-cecile
Copy link
Member

This is a breaking change as it alters the public interface. Can you put a changelog and migration guide section in the PR description?

IMO this could use a changelog, but there's no migration guide to write, as the type was useless.

@ickshonpe ickshonpe changed the title remove the QueuedText struct Remove QueuedText Jan 29, 2023
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jan 31, 2023
@ickshonpe
Remove QueuedText (#7414)
a441939 
## Objective

Remove `QueuedText`.

`QueuedText` isn't useful. It's exposed in the `bevy_ui` public interface but can't be used for anything because its `entities` field is private.

## Solution

Remove the `QueuedText` struct and use a `Local<Vec<Entity>` in its place.

## Changelog

* Removed `QueuedText`
@bors
Copy link
Contributor

bors bot commented Jan 31, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Remove QueuedText [Merged by Bors] - Remove QueuedText Jan 31, 2023
@bors bors bot closed this Jan 31, 2023
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@ickshonpe @ItsDoot
Remove QueuedText (bevyengine#7414)
7944a9b 
## Objective

Remove `QueuedText`.

`QueuedText` isn't useful. It's exposed in the `bevy_ui` public interface but can't be used for anything because its `entities` field is private.

## Solution

Remove the `QueuedText` struct and use a `Local<Vec<Entity>` in its place.

## Changelog

* Removed `QueuedText`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ickshonpe @james7132 @alice-i-cecile