Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some post-processing issues #7474

Closed
wants to merge 3 commits into from
Closed

fix some post-processing issues #7474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a0c92c
load and blend
robtfm Feb 2, 2023
1a4c8d5
bloom alpha
robtfm Feb 2, 2023
36274c2
update examples
robtfm Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion crates/bevy_core_pipeline/src/bloom/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,11 @@ impl FromWorld for BloomPipelines {
dst_factor: BlendFactor::One,
operation: BlendOperation::Add,
},
alpha: BlendComponent::REPLACE,
alpha: BlendComponent {
src_factor: BlendFactor::One,
dst_factor: BlendFactor::One,
operation: BlendOperation::Max,
},
}),
write_mask: ColorWrites::ALL,
})],
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_core_pipeline/src/upscaling/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ impl SpecializedRenderPipeline for UpscalingPipeline {
entry_point: "fs_main".into(),
targets: vec![Some(ColorTargetState {
format: key.texture_format,
blend: None,
blend: Some(BlendState::ALPHA_BLENDING),
write_mask: ColorWrites::ALL,
})],
}),
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_core_pipeline/src/upscaling/node.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ impl Node for UpscalingNode {
view: target.out_texture(),
resolve_target: None,
ops: Operations {
load: LoadOp::Clear(Default::default()),
load: LoadOp::Load,
store: true,
},
})],
Expand Down
2 changes: 1 addition & 1 deletion examples/3d/split_screen.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ fn setup(
},
camera_3d: Camera3d {
// don't clear on the second camera because the first camera already cleared the window
clear_color: ClearColorConfig::None,
clear_color: ClearColorConfig::Custom(Color::NONE),
..default()
},
..default()
Expand Down
2 changes: 1 addition & 1 deletion examples/3d/two_passes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ fn setup(
commands.spawn(Camera3dBundle {
transform: Transform::from_xyz(10.0, 10., -5.0).looking_at(Vec3::ZERO, Vec3::Y),
camera_3d: Camera3d {
clear_color: ClearColorConfig::None,
clear_color: ClearColorConfig::Custom(Color::NONE),
..default()
},
camera: Camera {
Expand Down