Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - introduce EntityLocation::INVALID const and adjust Entities::get comment #7623

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - introduce EntityLocation::INVALID const and adjust Entities::get comment #7623

wants to merge 4 commits into from

Conversation

shuoli84
Copy link
Contributor

also remove one un-needed mut.

@alice-i-cecile alice-i-cecile added the A-ECS Entities, components, systems, and events label Feb 11, 2023
@alice-i-cecile alice-i-cecile added the C-Code-Quality A section of code that is hard to understand or change label Feb 11, 2023
JoJoJet
JoJoJet approved these changes Feb 11, 2023
View reviewed changes
crates/bevy_ecs/src/entity/mod.rs Show resolved Hide resolved
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 11, 2023
@shuoli84
Copy link
Contributor Author

@james7132 ping

james7132
james7132 approved these changes Feb 18, 2023
View reviewed changes
Copy link
Member

@james7132 james7132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Feb 18, 2023
@shuoli84
introduce EntityLocation::INVALID const and adjust Entities::get comm…
609ad5a 
…ent (#7623)

also remove one un-needed mut.
@bors
Copy link
Contributor

bors bot commented Feb 18, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title introduce EntityLocation::INVALID const and adjust Entities::get comment [Merged by Bors] - introduce EntityLocation::INVALID const and adjust Entities::get comment Feb 18, 2023
@bors bors bot closed this Feb 18, 2023
myreprise1 pushed a commit to myreprise1/bevy that referenced this pull request Feb 20, 2023
@shuoli84 @myreprise1
introduce EntityLocation::INVALID const and adjust Entities::get comm…
4a123e2 
…ent (bevyengine#7623)

also remove one un-needed mut.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@JoJoJet JoJoJet JoJoJet approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shuoli84 @james7132 @alice-i-cecile @JoJoJet