[Merged by Bors] - Changes in the size of a text node should trigger recomputation of its text #7674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ickshonpe
changed the title
ickshonpe
changed the title
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Feb 14, 2023
mockersf
approved these changes
Feb 14, 2023
mockersf
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 14, 2023
…s text (#7674) # Objective The text contained by a text node is only recomputed when its `Style` or `Text` components change, or when the scale factor changes. Not when the geometry of the text node is modified. Make it so that any change in text node size triggers a text recomputation. ## Solution Change `text_system` so that it queries for text nodes with changed `Node` components and recomputes their text. --- Most users won't notice any difference but it should fix some confusing edge cases in more complicated and interactive layouts. ## Changelog * Added `Changed<Node>` to the change detection query of `text_system`. This ensures that any change in the size of a text node will cause any text it contains to be recomputed.
bors
bot
changed the title
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 15, 2023
…s text (bevyengine#7674) # Objective The text contained by a text node is only recomputed when its `Style` or `Text` components change, or when the scale factor changes. Not when the geometry of the text node is modified. Make it so that any change in text node size triggers a text recomputation. ## Solution Change `text_system` so that it queries for text nodes with changed `Node` components and recomputes their text. --- Most users won't notice any difference but it should fix some confusing edge cases in more complicated and interactive layouts. ## Changelog * Added `Changed<Node>` to the change detection query of `text_system`. This ensures that any change in the size of a text node will cause any text it contains to be recomputed.
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 15, 2023
…s text (bevyengine#7674) # Objective The text contained by a text node is only recomputed when its `Style` or `Text` components change, or when the scale factor changes. Not when the geometry of the text node is modified. Make it so that any change in text node size triggers a text recomputation. ## Solution Change `text_system` so that it queries for text nodes with changed `Node` components and recomputes their text. --- Most users won't notice any difference but it should fix some confusing edge cases in more complicated and interactive layouts. ## Changelog * Added `Changed<Node>` to the change detection query of `text_system`. This ensures that any change in the size of a text node will cause any text it contains to be recomputed.
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 15, 2023
…s text (bevyengine#7674) # Objective The text contained by a text node is only recomputed when its `Style` or `Text` components change, or when the scale factor changes. Not when the geometry of the text node is modified. Make it so that any change in text node size triggers a text recomputation. ## Solution Change `text_system` so that it queries for text nodes with changed `Node` components and recomputes their text. --- Most users won't notice any difference but it should fix some confusing edge cases in more complicated and interactive layouts. ## Changelog * Added `Changed<Node>` to the change detection query of `text_system`. This ensures that any change in the size of a text node will cause any text it contains to be recomputed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The text contained by a text node is only recomputed when its
StyleorTextcomponents change, or when the scale factor changes. Not when the geometry of the text node is modified.Make it so that any change in text node size triggers a text recomputation.
Solution
Change
text_systemso that it queries for text nodes with changedNodecomponents and recomputes their text.Most users won't notice any difference but it should fix some confusing edge cases in more complicated and interactive layouts.
Changelog
Changed<Node>to the change detection query oftext_system. This ensures that any change in the size of a text node will cause any text it contains to be recomputed.