[gltf] Support camera and fix hierarchy #772
Conversation
FuriouZz
force-pushed
the
feature/gltf-camera
branch
from
da044d7 to
ef79809
Compare
FuriouZz
force-pushed
the
feature/gltf-camera
branch
from
ef79809 to
24f44a2
Compare
karroffel
added
A-Assets
There was a problem hiding this comment.
Looks good to me! I tried testing this by exporting a blender gltf scene with a camera and was like "why isn't this working?". Turns out the blender gltf exporter doesn't export cameras by default 😄
Everything works as expected:
Blender (note that the cubes are a parent->child chain)
Bevy
crates/bevy_gltf/src/loader.rs
Outdated
| projection_matrix: projection.get_projection_matrix(), | ||
| ..Default::default() | ||
| }, | ||
| transform: Transform::from_matrix(Mat4::from_cols_array_2d( |
There was a problem hiding this comment.
the transform creation is shared across both projections and the else statement. can we move this to a variable on line 217?
|
I will take some time to check punctual lights import in a next PR. I think actually bevy only have a point light. |
|
I give a quick look at the file, and it looks similar of what I did to fix the gltf to load the bones hierarchy. *One note: first spawn the empty node and use the |
|
@lassade Thanks for the advice i didn't know how to do this. I will be glad to merge our efforts. |
Add support to camera import from a gltf scene