Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Update glam to 0.23 #7883

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Update glam to 0.23 #7883

wants to merge 3 commits into from

Conversation

geieredgar
Copy link
Contributor

@geieredgar geieredgar commented Mar 3, 2023 •
edited
Loading

Objective

  • Update glam to the latest version.

Solution

  • Update glam to version 0.23.

Since the breaking change in glam only affects the scalar-math feature, this should cause no issues.

@alice-i-cecile alice-i-cecile added C-Dependencies A change to the crates that Bevy depends on A-Math Fundamental domain-agnostic mathematical operations S-Blocked This cannot move forward until something else changes labels Mar 3, 2023
@JMS55 JMS55 added this to the 0.11 milestone Mar 3, 2023
@OptimisticPeach
Copy link
Contributor

Bumped & published hexasphere to 8.1.0 :)

@teoxoy
Copy link
Contributor

teoxoy commented Mar 4, 2023

encase v0.5 is up on crates.io (with updated glam dep)

@geieredgar geieredgar marked this pull request as ready for review March 4, 2023 10:52
@geieredgar geieredgar mentioned this pull request Mar 4, 2023
Closed
@james7132 james7132 requested a review from mockersf March 4, 2023 11:01
james7132
james7132 approved these changes Mar 4, 2023
View reviewed changes
Copy link
Member

@james7132 james7132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes.

@james7132 james7132 modified the milestones: 0.11, 0.10 Mar 4, 2023
@james7132 james7132 removed the request for review from mockersf March 4, 2023 11:02
@james7132 james7132 removed the S-Blocked This cannot move forward until something else changes label Mar 4, 2023
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 4, 2023
@mockersf
Copy link
Member

mockersf commented Mar 4, 2023

bors r+

bors bot pushed a commit that referenced this pull request Mar 4, 2023
@geieredgar
Update glam to 0.23 (#7883)
cbbf8ac 
# Objective

- Update `glam` to the latest version.

## Solution

- Update `glam` to version `0.23`.

Since the breaking change in `glam` only affects the `scalar-math` feature, this should cause no issues.
@bors
Copy link
Contributor

bors bot commented Mar 4, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Update glam to 0.23 [Merged by Bors] - Update glam to 0.23 Mar 4, 2023
@bors bors bot closed this Mar 4, 2023
@CGMossa
Copy link
Contributor

CGMossa commented Mar 4, 2023

Great job on this!

Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@geieredgar @Shfty
Update glam to 0.23 (bevyengine#7883)
21399eb 
# Objective

- Update `glam` to the latest version.

## Solution

- Update `glam` to version `0.23`.

Since the breaking change in `glam` only affects the `scalar-math` feature, this should cause no issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Dependencies A change to the crates that Bevy depends on S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.
8 participants
@geieredgar @OptimisticPeach @teoxoy @mockersf @CGMossa @james7132 @alice-i-cecile @JMS55