Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase type safety and clarity for change detection #7905

Merged
merged 22 commits into from
Mar 9, 2023
Merged

Increase type safety and clarity for change detection #7905

merged 22 commits into from
Mar 9, 2023

Commits on Mar 5, 2023

  1. use the Tick type for change ticks

    @JoJoJet
    JoJoJet committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    0dcbb3e View commit details
    Browse the repository at this point in the history

  2. use Tick in DetectChangesMut

    @JoJoJet
    JoJoJet committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    3c6910f View commit details
    Browse the repository at this point in the history

  3. rename locals to last_run and this_run

    @JoJoJet
    JoJoJet committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    f7d650b View commit details
    Browse the repository at this point in the history

  4. rename {g,s}et_last_change_tick to last_run

    @JoJoJet
    JoJoJet committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    dd9bf5e View commit details
    Browse the repository at this point in the history

  5. rename SystemMeta::last_change_tick

    @JoJoJet
    JoJoJet committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    fdcb88b View commit details
    Browse the repository at this point in the history

  6. rename stuff for SystemChangeTick

    @JoJoJet
    JoJoJet committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    4428354 View commit details
    Browse the repository at this point in the history

  7. rename more things to last_run

    @JoJoJet
    JoJoJet committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    66cfcd1 View commit details
    Browse the repository at this point in the history

  8. rewrite docs for Tick

    @JoJoJet
    JoJoJet committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    5400aa5 View commit details
    Browse the repository at this point in the history

  9. update ComponentTicks::set_changed

    @JoJoJet
    JoJoJet committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    bc7267f View commit details
    Browse the repository at this point in the history

  10. rename Tick::set_changed to set

    @JoJoJet
    JoJoJet committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    4afe50f View commit details
    Browse the repository at this point in the history

  11. remove incorrect duplicate docs

    @JoJoJet
    JoJoJet committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    6fd32f8 View commit details
    Browse the repository at this point in the history

  12. add Tick::relative_to to encapsulate subtraction

    @JoJoJet
    JoJoJet committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    9d94588 View commit details
    Browse the repository at this point in the history

  13. return Tick from DetectChanges

    @JoJoJet
    JoJoJet committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    4539841 View commit details
    Browse the repository at this point in the history

  14. encapsulate Tick::tick

    @JoJoJet
    JoJoJet committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    71c7271 View commit details
    Browse the repository at this point in the history

  15. encapsulate tick checks

    @JoJoJet
    JoJoJet committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    39043c9 View commit details
    Browse the repository at this point in the history

  16. encapsulate uses of MAX_CHANGE_TICK

    @JoJoJet
    JoJoJet committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    195dfc7 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. make relative_to pub(crate)

    @JoJoJet
    JoJoJet committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    7a9be98 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Merge remote-tracking branch 'upstream/main' into newtype-ticks

    @JoJoJet
    JoJoJet committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    0aaa1ae View commit details
    Browse the repository at this point in the history

  2. fix a merge error

    @JoJoJet
    JoJoJet committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    7a4b357 View commit details
    Browse the repository at this point in the history

  3. update a unit test

    @JoJoJet
    JoJoJet committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    bef9ce6 View commit details
    Browse the repository at this point in the history

  4. bless a compile fail test

    @JoJoJet
    JoJoJet committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    75d33a8 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/main' into newtype-ticks

    @JoJoJet
    JoJoJet committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    d1b7c09 View commit details
    Browse the repository at this point in the history