Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix name conflicts caused by the SystemParam and WorldQuery macros #8012

Merged
merged 21 commits into from
Mar 22, 2023
Merged

Fix name conflicts caused by the SystemParam and WorldQuery macros #8012

merged 21 commits into from
Mar 22, 2023

Commits on Mar 10, 2023

  1. add a regression test

    @JoJoJet
    JoJoJet committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    7a40865 View commit details
    Browse the repository at this point in the history

  2. fix the regression test

    @JoJoJet
    JoJoJet committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    0bf2c7f View commit details
    Browse the repository at this point in the history

  3. ensure state types don't collide for SystemParam

    @JoJoJet
    JoJoJet committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    7ad905c View commit details
    Browse the repository at this point in the history

  4. tweak regression test

    @JoJoJet
    JoJoJet committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    accbab9 View commit details
    Browse the repository at this point in the history

  5. add a dedicated method for generating identifiers with no collision

    @JoJoJet
    JoJoJet committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    df47636 View commit details
    Browse the repository at this point in the history

  6. add a regression test for queries

    @JoJoJet
    JoJoJet committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    952781f View commit details
    Browse the repository at this point in the history

  7. prevent collisions for WorldQuery state and fetch types

    @JoJoJet
    JoJoJet committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    47b21b9 View commit details
    Browse the repository at this point in the history

  8. add a comment describing the collision algorithm

    @JoJoJet
    JoJoJet committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    81fce59 View commit details
    Browse the repository at this point in the history

  9. remove a redundant import

    @JoJoJet
    JoJoJet committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    9df6846 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. use a more efficient collision checking algorithm

    @JoJoJet
    JoJoJet committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    99f1883 View commit details
    Browse the repository at this point in the history

  2. move ensure_no_collision to bevy_macro_utils

    @JoJoJet
    JoJoJet committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    c1de12f View commit details
    Browse the repository at this point in the history

  3. move a struct definition

    @JoJoJet
    JoJoJet committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    53cb5d7 View commit details
    Browse the repository at this point in the history

  4. use a hash set

    @JoJoJet
    JoJoJet committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    7827e79 View commit details
    Browse the repository at this point in the history

  5. factor out a regression test into a named test

    @JoJoJet
    JoJoJet committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    9289bb2 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. capitalize regression test comments

    @JoJoJet
    JoJoJet committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    cd5e92f View commit details
    Browse the repository at this point in the history

  2. don't use recursion to visit token trees

    @JoJoJet
    JoJoJet committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    fbae65f View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. use FxHash

    @JoJoJet
    JoJoJet committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    04ab144 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into state-name-conflict

    @JoJoJet
    JoJoJet committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    96a1d61 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2023

  1. Merge remote-tracking branch 'upstream/main' into state-name-conflict

    @JoJoJet
    JoJoJet committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    3801ddc View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2023

  1. Merge remote-tracking branch 'upstream/main' into state-name-conflict

    @JoJoJet
    JoJoJet committed Mar 19, 2023
    Configuration menu
    Copy the full SHA
    dca0f0c View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Merge remote-tracking branch 'upstream/main' into state-name-conflict

    @JoJoJet
    JoJoJet committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    cf8e525 View commit details
    Browse the repository at this point in the history