Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Val into two enums, one with an Auto variant and one without #8096

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Split Val into two enums, one with an Auto variant and one without #8096

wants to merge 28 commits into from
+1,029 −465

Commits on Feb 8, 2023

  1. changes: 

            Added a type `Breadth`, that is similar to `Val` but with only evaluatable variants.
        Gave UiRect a type parameter, so it can take `Breadth` or `Val` values.
        Added tests for `Breadth` and `UiRect`.
        Changed style properties to use `Breadth` instead of `Val` for the padding and border properties.
        Changed `bevy_ui::flex::convert::from_rect` to take an `UiRect<T: Into<Val>>` instead of a `UiRect`.
        Made minimal necessary changes to the examples.
    @ickshonpe
    ickshonpe committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    684b32a View commit details
    Browse the repository at this point in the history

  2. improved the Breadth doc comment description

    @ickshonpe
    ickshonpe committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    4b2c93b View commit details
    Browse the repository at this point in the history

  3. impl From<UiRect<Breadth> for <UiRect<Val> and use it to convert the … 

    …padding and border values in `bevy_ui::flex::convert::from_style`
    @ickshonpe
    ickshonpe committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    9597f15 View commit details
    Browse the repository at this point in the history

  4. cargo fmt --all

    @ickshonpe
    ickshonpe committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    7d02b25 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. added plugin type registrations for Breadth and UiRect<Breadth>

    @ickshonpe
    ickshonpe committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    7ef9ca4 View commit details
    Browse the repository at this point in the history

  2. Improved the doc comments for Breadth

    @ickshonpe
    ickshonpe committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    087fc9e View commit details
    Browse the repository at this point in the history

  3. collected and tidied up test imports

    @ickshonpe
    ickshonpe committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    d558224 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Merge branch 'breadth' into split-uirect

    @ickshonpe
    ickshonpe committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    785d320 View commit details
    Browse the repository at this point in the history

  2. changes: 

    * Renamed `Val` to `AutoVal`
* Renamed `Breadth` to `Val`
* Renamed `ValArithmeticError` to `AutoValArithmeticError`
* Renamed `BreadthArithmeticError` to `ValArithmeticError`
* Renamed `BreadthConversionError` to `ValConversionError`
    @ickshonpe
    ickshonpe committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    379388e View commit details
    Browse the repository at this point in the history

  3. changes: 

    * removed `UiRect` and added `Border`, `Padding` and `Margin` types.
* fixed examples
* fixed convert and added the style conversion helper functions from the grid PR.
* renamed tests to use the correct names for the new types.
    @ickshonpe
    ickshonpe committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    942f611 View commit details
    Browse the repository at this point in the history

  4. Changed geometry helper functions to take impl Into<AutoVal> parame… 

    …ters
    @ickshonpe
    ickshonpe committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    366f17e View commit details
    Browse the repository at this point in the history

  5. cleaned up the examples

    @ickshonpe
    ickshonpe committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    ab9e662 View commit details
    Browse the repository at this point in the history

  6. Fix doc tests

    @ickshonpe
    ickshonpe committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    cf87ae9 View commit details
    Browse the repository at this point in the history

  7. More doc text fixes

    @ickshonpe
    ickshonpe committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    c39d95c View commit details
    Browse the repository at this point in the history

  8. Fix doc comment errors

    @ickshonpe
    ickshonpe committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    29febb9 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Merge branch 'main' into split-uirect-merge

    @ickshonpe
    ickshonpe committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    492de41 View commit details
    Browse the repository at this point in the history

  2. more merge changes

    @ickshonpe
    ickshonpe committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    0488c26 View commit details
    Browse the repository at this point in the history

  3. Fixed some examples

    @ickshonpe
    ickshonpe committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    53461c9 View commit details
    Browse the repository at this point in the history

  4. Renamed AutoVal to Val and Val to Num.

    @ickshonpe
    ickshonpe committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    bbae861 View commit details
    Browse the repository at this point in the history

  5. More merge fixes

    @ickshonpe
    ickshonpe committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    e742dfc View commit details
    Browse the repository at this point in the history

  6. More merge fixes

    @ickshonpe
    ickshonpe committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    907ead4 View commit details
    Browse the repository at this point in the history

  7. fixed more examples

    @ickshonpe
    ickshonpe committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    97b8fa0 View commit details
    Browse the repository at this point in the history

  8. fixed game_menu example

    @ickshonpe
    ickshonpe committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    de76437 View commit details
    Browse the repository at this point in the history

  9. More merge fixes

    @ickshonpe
    ickshonpe committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    87ba5fa View commit details
    Browse the repository at this point in the history

  10. cargo fmt --all

    @ickshonpe
    ickshonpe committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    084f5b8 View commit details
    Browse the repository at this point in the history

  11. Renamed ValArithmeticError to NumArithmeticError and `AutoValArit… 

    …hmeticError` to `ValArithmeticError`
    @ickshonpe
    ickshonpe committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    f334985 View commit details
    Browse the repository at this point in the history

  12. ValConversionError renamed to NumConversionError

    @ickshonpe
    ickshonpe committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    6cd390f View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Removed references to AutoVal in comments. Fixed doc comments for `… 

    …Num` helper functions.
    @ickshonpe
    ickshonpe committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    3fb9b65 View commit details
    Browse the repository at this point in the history