Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak many gizmos stress test #8309

Closed
wants to merge 2 commits into from
Closed

Conversation

vby
Copy link

@vby vby commented Apr 6, 2023

Objective

Make the stress test example many_gizmos a little bit more fun.

Solution

Draw random lines in a cube, seeding by the elapsed seconds.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@vby vby force-pushed the tweak_many_gizmos branch 3 times, most recently from c20bec9 to 5cdab7a Compare April 6, 2023 07:12
@james7132 james7132 added C-Examples An addition or correction to our examples A-Gizmos Visual editor and debug gizmos labels Apr 17, 2023
Copy link
Member

@james7132 james7132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variability introduced by this make it difficult to use this as a stress test. Not sure if we should do this.

@nicopap
Copy link
Contributor

nicopap commented Apr 18, 2023

This was discussed in the gizmos PR. #6529 (comment)

I agree with james in that it makes it difficult to use it as a benchmark.

Maybe instead of replacing the "simple" setup, you could add more setups? Replacing Config.fancy: bool by an enum that cycles between "simple black line" "disc", "cube" etc.

@vby
Copy link
Author

vby commented Apr 20, 2023

Remove variability if fancy is off, the state is constant now.

@vby vby closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Gizmos Visual editor and debug gizmos C-Examples An addition or correction to our examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants