Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing bevy_text feature cfg attribute #8670

Conversation

ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented May 24, 2023

Objective

The TextFlags import in bevy_ui::node_bundles is missing the #[cfg(feature = "bevy_text")] attribute.

@ickshonpe ickshonpe changed the title Add #[cfg(feature = "bevy_text")] to the TextFlags import in bevy_ui::node_bundles. Fix missing bevy_text feature attribute for TextFlags import in bevy_ui::node_bundles. May 31, 2023
@ickshonpe ickshonpe changed the title Fix missing bevy_text feature attribute for TextFlags import in bevy_ui::node_bundles. Add missing bevy_text feature attribute for the TextFlags import in bevy_ui::node_bundles. May 31, 2023
@ickshonpe ickshonpe changed the title Add missing bevy_text feature attribute for the TextFlags import in bevy_ui::node_bundles. Add missing bevy_text feature cfg attribute for the TextFlags import in bevy_ui::node_bundles. May 31, 2023
@ickshonpe ickshonpe changed the title Add missing bevy_text feature cfg attribute for the TextFlags import in bevy_ui::node_bundles. Fix missing bevy_text feature cfg attribute Jun 16, 2023
@ickshonpe
Copy link
Contributor Author

@mockersf can we get this merged, it's very trivial and needs to be fixed

@cart cart added this pull request to the merge queue Jun 29, 2023
Merged via the queue into bevyengine:main with commit f4fdbef Jun 29, 2023
@nicopap
Copy link
Contributor

nicopap commented Jun 29, 2023

This still doesn't compile, due to the Without being imported only with feature = "bevy_text" in the same file, while being used even when the feature is disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants