Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain usage of prepass shaders in docs for Material trait #9025

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Explain usage of prepass shaders in docs for Material trait #9025

merged 1 commit into from
Oct 16, 2023

Conversation

geieredgar
Copy link
Contributor

Objective

Solution

  • Added a paragraph describing the usage of the prepass_vertex_shader and prepass_fragment_shader.

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Rendering Drawing game state to the screen labels Jul 4, 2023
Selene-Amanita
Selene-Amanita approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@Selene-Amanita Selene-Amanita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detail: the doc for bevy_core_pipeline::prepass doesn't mention shadow mapping, is there somewhere else in the doc that references that?

@JMS55 JMS55 added this to the 0.12 milestone Sep 28, 2023
@alice-i-cecile alice-i-cecile removed this from the 0.12 milestone Sep 29, 2023
@IceSentry IceSentry added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 13, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 16, 2023
Merged via the queue into bevyengine:main with commit e23d7cf Oct 16, 2023
1 check passed
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@geieredgar @ameknite
Explain usage of prepass shaders in docs for Material trait (bevyen…
bc9fcab 
…gine#9025)

# Objective

- Fixes bevyengine#8696.

## Solution

- Added a paragraph describing the usage of the `prepass_vertex_shader`
and `prepass_fragment_shader`.
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@geieredgar
Explain usage of prepass shaders in docs for Material trait (bevyen…
bb33cf0 
…gine#9025)

# Objective

- Fixes bevyengine#8696.

## Solution

- Added a paragraph describing the usage of the `prepass_vertex_shader`
and `prepass_fragment_shader`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceSentry IceSentry IceSentry approved these changes

@Selene-Amanita Selene-Amanita Selene-Amanita approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Material trait doesn't mention that prepass shaders are used for shadow mapping
5 participants
@geieredgar @IceSentry @Selene-Amanita @alice-i-cecile @JMS55