Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete initialization of plugins in App::run #9066

Closed
wants to merge 2 commits into from
Closed

Complete initialization of plugins in App::run #9066

wants to merge 2 commits into from

Conversation

B-head
Copy link
Contributor

@B-head B-head commented Jul 7, 2023 •
edited
Loading

This pull request is mutually exclusive with #9054.

Objective

Completing plugin initialization in App::run will prevent new bugs caused by uninitialized plugins in the runner function.

Solution

Wait for asynchronous tasks to complete, then for each calls Plugin::finish and Plugin::cleanup in App::run.

Changelog

  • Changed to complete initialization of plugins with App::run.
  • Removed App::ready.
  • Removed App::finish.
  • Removed App::cleanup.

Migration Guide

Remove the plugin initialization code in the runner function because plugin initialization is complete in App::run.

@B-head B-head mentioned this pull request Jul 7, 2023
Merged
@B-head B-head changed the title Complete initialization of plugins with App::run Complete initialization of plugins in App::run Jul 7, 2023
@Selene-Amanita Selene-Amanita added A-App Bevy apps and plugins C-Bug An unexpected or incorrect behavior M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Jul 9, 2023
github-merge-queue bot pushed a commit that referenced this pull request Jul 9, 2023
@B-head
Fix not calling App::finish and App::cleanup in `ScheduleRunnerPl…
f213c14 
…ugin` (#9054)

This pull request is mutually exclusive with #9066.

# Objective

Complete the initialization of the plugin in `ScheduleRunnerPlugin`.

## Solution

Wait for asynchronous tasks to complete, then `App::finish` and
`App::cleanup` in the runner function.
@hymm hymm self-requested a review July 11, 2023 16:19
@rparrett
Copy link
Contributor

rparrett commented Jan 9, 2024

With #9054 merged, it looks like this can be closed.

@rparrett rparrett closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hymm hymm Awaiting requested review from hymm

Assignees
No one assigned
Labels
A-App Bevy apps and plugins C-Bug An unexpected or incorrect behavior M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@B-head @rparrett @Selene-Amanita