Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow despawning of hierarchies in threadlocal systems #908

Merged
merged 3 commits into from
Nov 26, 2020

Conversation

svents
Copy link
Contributor

@svents svents commented Nov 21, 2020

Currently, one can despawn hierarchies with commands, but not conveniently via the world. I made the function in question public. In addition, I tried to write the recursive despawn a bit more compactly (in separate commits).

@Moxinilian Moxinilian added A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible labels Nov 22, 2020
@cart
Copy link
Member

cart commented Nov 22, 2020

I like this, but can we revert back to recursion instead of using a heap-based stack?

@svents
Copy link
Contributor Author

svents commented Nov 23, 2020

Done. The swapping of children might be worth keeping, but if not, please just rebase it out.

@cart
Copy link
Member

cart commented Nov 26, 2020

Definitely worth keeping. Im all for reducing allocations!

@cart cart merged commit 6960390 into bevyengine:master Nov 26, 2020
@ambeeeeee ambeeeeee mentioned this pull request Nov 28, 2020
@fopsdev fopsdev mentioned this pull request Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants