Clarify immediate mode in Gizmos documentation
#9183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Selene-Amanita
added
C-Docs
james7132
approved these changes
Jul 17, 2023
mockersf
reviewed
Jul 17, 2023
@SpecificProtagonist Maybe "This should be called for each frame the […] need to be rendered."? Before the end of Last, or before a specific system in Last? |
Sure, that's fine too.
Before |
Co-authored-by: SpecificProtagonist <vincentjunge@posteo.net>
…", clarify linestrip, fix arc
SpecificProtagonist
approved these changes
Jul 18, 2023
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Selene-Amanita
added
the
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Jul 31, 2023
cart
pushed a commit
that referenced
this pull request
Aug 10, 2023
# Objective - Repeat in `Gizmos` that they are drawned in immediate mode, which is said at the module level but not here, and detail what it means. - Clarify for every method of `Gizmos` that they should be called for every frame. - Clarify which methods belong to 3D or 2D space (kinda obvious for 2D but still) The first time I used gizmos I didn't understand how they work and was confused as to why nothing showed up. --------- Co-authored-by: François <mockersf@gmail.com> Co-authored-by: SpecificProtagonist <vincentjunge@posteo.net> Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Gizmosthat they are drawned in immediate mode, which is said at the module level but not here, and detail what it means.Gizmosthat they should be called for every frame.The first time I used gizmos I didn't understand how they work and was confused as to why nothing showed up.