Make WgpuSettings::default() check WGPU_POWER_PREF #9482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
fornwall
changed the title
This is useful when testing, and makes the behaviour consistent with the already present check for WGPU_BACKEND.
fornwall
force-pushed
the
wgpu-power-pref-env
branch
from
3720ffa
to
64dfd86
Compare
|
Example |
1 similar comment
|
Example |
superdump
approved these changes
Aug 18, 2023
mockersf
approved these changes
Aug 18, 2023
mockersf
added
A-Rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Allow users to specify the power preference when selecting a wgpu adapter, which is useful for testing or workaround purposes, and makes the behaviour consistent with the already present check for
WGPU_BACKEND.Solution
In
WgpuSettings::default(), allow users to specify theWGPU_POWER_PREFto affect the wgpu adapter choice.