Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bent normals to SSAO #9519

Closed
wants to merge 1 commit into from
Closed

Add bent normals to SSAO #9519

wants to merge 1 commit into from

Conversation

JMS55
Copy link
Contributor

@JMS55 JMS55 commented Aug 20, 2023

Objective

  • Improve indirect lighting quality by estimating the direction of least occlusion while calculating SSAO, and using that as the normal for indirect lighting calculations
  • Add support for WebGPU to SSAO
  • Should not be merged until after wgpu 0.17 #9302

Changelog

This section is optional. If this was a trivial fix, or has no externally-visible impact, you can delete this section.

  • What changed as a result of this PR?
  • If applicable, organize changes under "Added", "Changed", or "Fixed" sub-headings
  • Stick to one or two sentences. If more detail is needed for a particular change, consider adding it to the "Solution" section
    • If you can't summarize the work, your change may be unreasonably large / unrelated. Consider splitting your PR to make it easier to review and merge!

Migration Guide

This section is optional. If there are no breaking changes, you can delete this section.

  • If this PR is a breaking change (relative to the last release of Bevy), describe how a user might need to migrate their code to support these changes
  • Simply adding new functionality is not a breaking change.
  • Fixing behavior that was definitely a bug, rather than a questionable design choice is not a breaking change.

@JMS55 JMS55 marked this pull request as draft August 20, 2023 22:45
@JMS55 JMS55 added the A-Rendering Drawing game state to the screen label Aug 20, 2023
@JMS55 JMS55 added this to the 0.12 milestone Aug 20, 2023
@alice-i-cecile alice-i-cecile added C-Feature A new feature, making something new possible S-Blocked This cannot move forward until something else changes labels Aug 21, 2023
@JMS55 JMS55 removed this from the 0.12 milestone Sep 18, 2023
@rparrett rparrett removed the S-Blocked This cannot move forward until something else changes label Feb 2, 2024
@JMS55 JMS55 closed this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants